Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 30, 2024. It is now read-only.

Conversation

holgerd77
Copy link
Member

These checks failed on the last PR submitted: #135

This is a test of CI along with some dependency updates.

@holgerd77 holgerd77 force-pushed the test-ci-runs-on-node-12-14 branch from 5d12854 to 282d91a Compare September 15, 2020 12:14
@coveralls
Copy link

coveralls commented Sep 15, 2020

Coverage Status

Coverage decreased (-1.3%) to 85.294% when pulling e3d9900 on test-ci-runs-on-node-12-14 into 744a79d on master.

@holgerd77
Copy link
Member Author

@evertonfraga @ryanio any ideas from the CI pros here why Node 14 is failing? 🤔

@evertonfraga
Copy link
Contributor

The first failure I could detect was on this badge update PR: #134. As there wasn't any other code change on that matter, I strongly suspect of an in-range dependency that got recently updated.

Some info:

  • The problem occurs after all tests are executed.
  • I can't reproduce it locally with Node 14 on Mac.
  • The error message "Segmentation fault (core dumped)" comes from C/C++, so either NodeJS core or an extension of it.

I'll keep looking into it.

@evertonfraga
Copy link
Contributor

Locked to the same v14.9.0 node version and had issues as well. Investigating...

image

@evertonfraga
Copy link
Contributor

Update:

To debunk the hypothesis that a dependency upgrade is causing this issue, I grabbed a package-lock.json generated before the observed failures, and have installed the dependencies from the lockfile using npm ci, but the tests still fail.

Heading back to github actions, the last node-14 green test was using v14.4.0. The failure was introduced along with the image update to 14.9.0.

So right now, I am testing with several node 14.x versions, to better know what version has introduced the segfault to our code.

On another track, I'm trying to detect the root cause, running tests locally.

@evertonfraga
Copy link
Contributor

evertonfraga commented Oct 6, 2020

Extended node versions until 14.13 and the issue persists. I need to give a closer look on local tests.

@holgerd77
Copy link
Member Author

@evertonfraga ok, thanks for keeping on with this a bit

@ryanio
Copy link
Collaborator

ryanio commented Oct 8, 2021

Looks like the ci is resolving now with all node versions with updated dependencies

@ryanio ryanio closed this Oct 8, 2021
@ryanio ryanio deleted the test-ci-runs-on-node-12-14 branch October 8, 2021 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants