Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(patterns): add context and crops_profile frontmatter to group 1 - #111

Merged
rymnc merged 2 commits into
masterfrom
chore/crops-group1-patterns
Mar 17, 2026
Merged

rymnc merged 2 commits into
masterfrom
chore/crops-group1-patterns

Conversation

@rymnc

@rymnc rymnc commented Mar 11, 2026

Copy link
Copy Markdown
Member

What are you adding?

  • Vendor/Protocol
  • Enterprise Use Case
  • Update to existing content
  • Other

Description

adding crops_profile and context frontmatter to group 1

Checklist

  • I've checked this doesn't duplicate existing content
  • All links work
  • Info is accurate

@rymnc rymnc self-assigned this Mar 11, 2026
@rymnc rymnc linked an issue Mar 11, 2026 that may be closed by this pull request
24 tasks
@rymnc

rymnc commented Mar 11, 2026

Copy link
Copy Markdown
Member Author

we skipped the L2 Privacy Evaluation Framework pattern, crops doesn't apply here

@rymnc
rymnc force-pushed the chore/crops-group1-patterns branch from 97e5f86 to 214776b Compare March 12, 2026 05:24
@rymnc
rymnc marked this pull request as ready for review March 12, 2026 06:03
@rymnc
rymnc requested review from Meyanis95 and oskarth March 12, 2026 06:03
Comment thread patterns/pattern-co-snark.md Outdated
- Requires new infra (MPC nodes, co-prover setup).
- Delegated proving possible, but introduces new trust assumptions.
- Honest-majority assumption: if a majority of proving parties collude, proof integrity is compromised.
- **CROPS improvement path**: CR → high by adding economic incentives (bond-backed provers with slashing for Byzantine behavior); OS → yes by open-sourcing the full co-SNARK implementation (TACEO/ABY3 primitives); Security → high by replacing trusted setup with universal setup.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we align on the same format for this line?

@rymnc rymnc Mar 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 15fa677

Comment thread patterns/pattern-co-snark.md Outdated
context: both
crops_profile:
cr: medium
os: partial

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/TaceoLabs/co-snarks

The above is open and MIT licensed. Should we promote it to yes?

@rymnc rymnc Mar 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 15fa677

Comment thread patterns/pattern-commit-and-prove.md Outdated
- No built-in privacy of amounts.
- Irreversibility: once one chain finalizes, that leg cannot be rolled back.
- Refunds/time-locks are required to mitigate stuck or one-sided settlements.
- **CROPS improvement path**: CR → high by adding protocol-enforced timelocks with forced-withdrawal on both chains; OS → yes by open-sourcing coordination logic under permissive license; Privacy → full by routing commitments through a shielded pool before attestation; Security → high by replacing irreversibility risk with guaranteed revert paths and verifiable finality proofs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand the path using a shielded pool. But a commit and reveal scheme can be turned fully private, with a ZKP proving knowledge of the pre-image without revealing it for example.

@rymnc rymnc Mar 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 15fa677

Comment thread patterns/pattern-commit-and-prove.md Outdated
- ERC-7573, EAS (commit attestations)
context: both
crops_profile:
cr: low

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what motivates this to be low.
You just need a hash function. For privacy, you can combine hash + zkp, both primitives have open tools to build it.

@rymnc rymnc Mar 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 15fa677


## Trade-offs

### Trust Model Comparison

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we split all these? How do you feel about having all these paths within the same CROPS assessment?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure, can address in follow up pr

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel this could be discarded, it's redundant with patter-shielding, plus it feels closer to an approach (shielding + ERC-7573).

@rymnc rymnc Mar 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 15fa677

@rymnc
rymnc force-pushed the chore/crops-group1-patterns branch from 214776b to 15fa677 Compare March 12, 2026 18:35
@rymnc
rymnc requested a review from Meyanis95 March 12, 2026 18:37
@rymnc
rymnc merged commit f451ae5 into master Mar 17, 2026
6 checks passed
@rymnc
rymnc deleted the chore/crops-group1-patterns branch March 17, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(patterns): crops-align patterns (group 1)

2 participants