Made in-memory database return Promises instead of sync results #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now this may seem as redundant, but in the future we may add tracing, single writer which will add the need to Promises. Also, we should make it closer to Pongo definitions. Better to do those breaking changes sooner than later.
68ae90d to
8576219
Compare
…oryDocumentsCollection This will make it more explicit, especially that some signatures like find by predicate already assume that, in the future we may add signature when needed.
8576219 to
5b31f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Made in-memory database return Promises instead of sync results
For now, this may seem redundant, but in the future, we may add tracing and a single writer, which will require Promises. Also, we should make it closer to Pongo definitions.
Better to do those breaking changes sooner rather than later.
2. Renamed the Database to the InMemoryDatabase and DocumentsCollection to InMemoryDocumentsCollection.
This will make it more explicit, especially since some signatures, like find by predicate, already assume that we may add a base signature when needed in the future.
@stepaniukm @GaryACraine @mbirkegaard FYI