Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v1.x #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I see I need to disable cert validation on SQL connection in tests... Work ongoing... ... Done |
janrybka
commented
Apr 2, 2024
| @@ -50,7 +50,8 @@ public static MsSqlConnectionString CreateConnectionString(string label) | |||
| { | |||
| DataSource = FirstNonEmpty( | |||
| Environment.GetEnvironmentVariable("EVENTFLOW_MSSQL_SERVER"), | |||
| ".") | |||
| "."), | |||
| Encrypt = false | |||
There was a problem hiding this comment.
Trust Server Cert wasn't working (I assume with SQL Server 2017), so I just disabled encryption. It's not required for tests.
|
@janrybka there seems to be something odd with the CLA. Are your commits done using an email verified on GitHub? |
Yes, I used the wrong one on this repo. Fixed. |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in of update in discussion: #1022 (comment)
This is first PR. The second will be to
develop-v0. Unfortunately I don't have any sample project to run tests on. Changes looks straight forward, build and unit tests passes, so there shouldn't be problems with runtime library mismatches.I'm currently running test on v0 version. I'll post those once finished.