Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move EventDispatcher setup to EventDispatcherService #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
glensc wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Move EventDispatcher setup to EventDispatcherService #966

glensc wants to merge 4 commits into from

Conversation

@glensc
Copy link
Member

@glensc glensc commented Nov 16, 2020 •
edited
Loading

The intent is to deprecate EventManager class

-Eventum\EventDispatcher\EventManager::dispatch(...);
+Eventum\ServiceContainer::dispatch(...);

@glensc glensc added this to the 3.9.8 milestone Nov 16, 2020
@glensc glensc self-assigned this Nov 16, 2020
@glensc glensc changed the title Move EventDispatcher setup to EventDispatcherService service provider Deprecate EventManager class Nov 16, 2020
@glensc glensc force-pushed the EventDispatcherService branch from cce13ba to 4e37c4f Compare November 16, 2020 07:20
@glensc
Copy link
Member Author

glensc commented Nov 23, 2020

This code created dependency loop:

app.ERROR: Unable to create Subscriber\IrcNotifySubscriber: Maximum function nesting level of '250' reached, aborting! {"exception":"[object] (Error(co
de: 0): Maximum function nesting level of '250' reached, aborting! at src/ServiceContainer.php:29)

@glensc glensc marked this pull request as draft November 30, 2020 00:14
@glensc glensc modified the milestones: 3.9.8, 3.9.9 Nov 30, 2020
@glensc glensc modified the milestones: 3.9.9, 3.9.10 Dec 31, 2020
@glensc glensc modified the milestones: 3.9.10, 3.9.11 Jan 25, 2021
@glensc glensc removed this from the 3.9.11 milestone Mar 7, 2021
@glensc glensc mentioned this pull request Mar 25, 2021
Merged
@glensc glensc force-pushed the EventDispatcherService branch 5 times, most recently from bdf654e to ae1244e Compare March 29, 2021 16:50
@glensc
Copy link
Member Author

glensc commented Mar 30, 2021

Recursion test:

[~/scm/eventum/eventum (EventDispatcherService)★] ➔ ./bin/console.php -vvv
Segmentation fault: 11

@glensc glensc mentioned this pull request Mar 30, 2021
Merged
@glensc glensc changed the title Deprecate EventManager class Move EventDispatcher setup to EventDispatcherService Mar 30, 2021
@glensc glensc force-pushed the EventDispatcherService branch from ae1244e to 6542603 Compare March 30, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@glensc glensc

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@glensc