Fix issue # 991 #1019
Merged
Fix issue # 991 #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proves that the current implementation of csv.readFile parses strings
that satisfy the regex /^\d{4}-?\d/ as if they were dates.
Passes tests for issue 991. Dayjs and momentjs do not have identical APIs. Original implementation of dayjs substituted all references to "momentjs" with "dayjs". There is no dayjs.ISO_8601 constant. Dayjs must be extended with a plugin to customize date parsing format. Dayjs does not accept an array of date formats as an argument.
Adjusts default dateFormat strings to be aligned with intended default behavior.
|
I'm a bit late to this party, sorry. I think I've identified a further problem with dayjs that means this fix does not fully solve the problem. Please see #991 |
|
Can confirm, 'D/M/YY' pattern breaks test with 'NZ1019316'. Dayjs appears to have further issues as @damianaiamad identified in #991. Reverting to moment is definitely a solution (wasn't broke, why fix it?), if the size of that module is not still a concern as it was in issue #794. |
|
One advantage of @LibertyNJ's solution is that it allows turning off automatic date parsing as follows:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where the csv.read/readFile method will incorrectly parse certain strings as dates that should not be dates. This may stem from differences in the API of momentjs and dayjs that were not addressed after migration.
By default dayjs will transform any string that matches the regex /^\d{4}-?\d/ into a valid date, whether it makes sense for that string to be interpreted as a date or not. This appears to be intended behavior on the part of dayjs, as it lets the module parse dates from strings in non-standard formats. If this is not the intended behavior of the csv.read/readFile methods, the default options.map method needs some more logic to help decide when to return a date.