Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Typing Table add row optional rowNumber #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Typing Table add row optional rowNumber #1544

merged 1 commit into from
Nov 30, 2020

Conversation

Andries-Smit
Copy link
Contributor

Summary

Using typescript the Table function addRow has a rowNumber parameter which is required but should be optional.

In the implementation https://github.com/exceljs/exceljs/blob/master/lib/doc/table.js#L341 there is a checks for undefined. And described in the comment above either insert at rowNumber or append

@alubbe alubbe merged commit e1de626 into exceljs:master Nov 30, 2020
@alubbe
Copy link
Member

alubbe commented Nov 30, 2020

Thank you!

@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alubbe alubbe alubbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andries-Smit @alubbe