Fix issue #163: the "spans" attribute of the row element is optional #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, waiting for the merge and NPM publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "spans" attribute is not required in the "row" element. Source of information: https://msdn.microsoft.com/en-us/library/office/documentformat.openxml.spreadsheet.row.aspx
If we create a Google Sheets spreadsheet and download it as XLSX, then the "spans" attributes do not appear in the "row" elements of the worksheet.
Attached is a test xlsx file, which causes the "Cannot read property 'split' of undefined" error when trying to read it with the exceljs package.
test-issue-163.xlsx