Thanks to visit codestin.com
Credit goes to github.com

Skip to content

README.md to have correct link for Streaming XLSX #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2023
Merged

README.md to have correct link for Streaming XLSX #2186

merged 3 commits into from
Apr 14, 2023

Conversation

wulfsolter
Copy link
Contributor

In README.md, currently "Streaming XLSX" links to wrong place

@Siemienik Siemienik self-assigned this Apr 6, 2023
coder-xiaotian
coder-xiaotian approved these changes Apr 13, 2023
View reviewed changes
Copy link

@coder-xiaotian coder-xiaotian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! Thank you for your correction.

@Siemienik
Copy link
Member

We will check, review and merge this PR on MergeFest II 14th April 2023 at 3 PM CEST.

Siemienik
Siemienik approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Siemienik Siemienik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.
I checked also _zh.md version, there is correct link.

@Siemienik Siemienik merged commit fd72705 into exceljs:master Apr 14, 2023
@j-mendez j-mendez mentioned this pull request Sep 8, 2024
Open
@Vishwas1 Vishwas1 mentioned this pull request Sep 8, 2024
Open
@j-mendez j-mendez mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siemienik Siemienik Siemienik approved these changes

+3 more reviewers

@naorpeled naorpeled naorpeled approved these changes

@venkatakrishna874 venkatakrishna874 venkatakrishna874 approved these changes

@coder-xiaotian coder-xiaotian coder-xiaotian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Siemienik Siemienik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wulfsolter @Siemienik @naorpeled @venkatakrishna874 @coder-xiaotian