Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove empty worksheet[0] from _worksheets #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2016
Merged

remove empty worksheet[0] from _worksheets #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/doc/workbook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ Workbook.prototype = {

get worksheets() {
// return a clone of _worksheets
return this._worksheets.filter(function(worksheet) { return worksheet; });
return this._worksheets.filter(Boolean);
},

eachSheet: function(iteratee) {
Expand All @@ -140,7 +140,7 @@ Workbook.prototype = {
lastPrinted: this.lastPrinted,
created: this.created,
modified: this.modified,
worksheets: this._worksheets.map(function(worksheet) { return worksheet.model; }),
worksheets: this._worksheets.filter(Boolean).map(function(worksheet) { return worksheet.model; }),
definedNames: this._definedNames.model,
views: this.views,
company: this.company,
Expand Down Expand Up @@ -189,4 +189,4 @@ Workbook.prototype = {
this._definedNames.model = value.definedNames;
this.views = value.views;
}
};
};
6 changes: 3 additions & 3 deletions lib/stream/xlsx/workbook-writer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ WorkbookWriter.prototype = {
var self = this;
return new Bluebird(function(resolve) {
var model = {
worksheets: self._worksheets
worksheets: self._worksheets.filter(Boolean)
};
var xform = new ContentTypesXform();
var xml = xform.toXml(model);
Expand All @@ -240,7 +240,7 @@ WorkbookWriter.prototype = {
var self = this;
return new Bluebird(function(resolve) {
var model = {
worksheets: self._worksheets
worksheets: self._worksheets.filter(Boolean)
};
var xform = new AppXform();
var xml = xform.toXml(model);
Expand Down Expand Up @@ -300,7 +300,7 @@ WorkbookWriter.prototype = {
addWorkbook: function() {
var zip = this.zip;
var model = {
worksheets: this._worksheets,
worksheets: this._worksheets.filter(Boolean),
definedNames: this._definedNames.model,
views: this.views
};
Expand Down