Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support error references in cell ranges #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2017
Merged

Support error references in cell ranges #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0497e8c
Support error references in cell ranges
holm Mar 27, 2017
f6d6907
Add non-capturing groups to simplify a bit
holm Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lib/utils/col-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,12 @@ var colCache = module.exports = {

// convert [sheetName!][$]col[$]row[[$]col[$]row] into address or range structures
decodeEx: function(value) {
var sheetName;
var groups = value.match(/(?:(?:(?:'((?:[^']|'')*)')|([^'^ ^!]*))!)?(.*)/);

var parts = value.split('!');
if (parts.length > 1) {
value = parts.pop();
sheetName = parts.join('!').replace(/^'|'$/g, '');
}
var sheetName = groups[1] || groups[2]; // Qouted and unqouted groups
var reference = groups[3]; // Remaining address

parts = value.split(':');
var parts = reference.split(':');
if (parts.length > 1) {
var tl = this.decodeAddress(parts[0]);
var br = this.decodeAddress(parts[1]);
Expand All @@ -192,8 +189,10 @@ var colCache = module.exports = {
br: { address: br, col: right, row: bottom, $col$row: '$' + this.n2l(right) + '$' + bottom, sheetName: sheetName },
dimensions: tl + ':' + br
};
} else if (reference.startsWith('#')) {
return sheetName ? {sheetName: sheetName, error: reference} : {error: reference};
} else {
var address = this.decodeAddress(value);
var address = this.decodeAddress(reference);
return sheetName ? Object.assign({sheetName: sheetName}, address) : address;
}
},
Expand Down
1 change: 1 addition & 0 deletions spec/unit/utils/col-cache.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ describe('colCache', function() {
expect(colCache.decodeEx('Sheet1!$H$1')).to.deep.equal({'$col$row':'$H$1', address:'H1', col:8, row:1, sheetName:'Sheet1'});
expect(colCache.decodeEx("'Sheet 1'!$H$1")).to.deep.equal({'$col$row':'$H$1', address:'H1', col:8, row:1, sheetName:'Sheet 1'});
expect(colCache.decodeEx("'Sheet !$:1'!$H$1")).to.deep.equal({'$col$row':'$H$1', address:'H1', col:8, row:1, sheetName:'Sheet !$:1'});
expect(colCache.decodeEx("'Sheet !$:1'!#REF!")).to.deep.equal({sheetName:'Sheet !$:1', error:'#REF!'});
});
});

Expand Down