Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Get the right text out of hyperlinked formula cells #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2018
Merged

Get the right text out of hyperlinked formula cells #552

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c75f87
Support hyperlinks parsing
holm Jun 20, 2017
40865c9
Use result for formula hyperlinks
holm Jun 22, 2017
f741004
Add test
papandreou Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use result for formula hyperlinks
  • Loading branch information
@holm @papandreou
holm authored and papandreou committed Apr 25, 2018
commit 40865c998488658e3b6467ef10fbffd26acdc893
9 changes: 7 additions & 2 deletions lib/xlsx/xform/sheet/cell-xform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,9 +427,14 @@ utils.inherits(CellXform, BaseXform, {
// look for hyperlink
var hyperlink = options.hyperlinkMap[model.address];
if (hyperlink) {
if (model.type === Enums.ValueType.Formula) {
model.text = model.result;
model.result = undefined;
} else {
model.text = model.value;
model.value = undefined;
}
model.type = Enums.ValueType.Hyperlink;
model.text = model.value;
model.value = undefined;
model.hyperlink = hyperlink;
}
}
Expand Down