Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Decode the _x<4 hex chars>_ escape notation in shared strings #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Decode the _x<4 hex chars>_ escape notation in shared strings #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/xlsx/xform/strings/text-xform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ utils.inherits(TextXform, BaseXform, {
},

get model() {
return this._text.join('');
return this._text.join('').replace(/_x([0-9A-F]{4})_/g, function($0, $1) {
return String.fromCharCode(parseInt($1, 16));
});
},

parseOpen: function(node) {
Expand Down
Binary file added spec/integration/data/shared_string_with_escape.xlsx
View file
Open in desktop
Binary file not shown.
16 changes: 16 additions & 0 deletions spec/integration/workbook-xlsx-reader.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,20 @@ describe('WorkbookReader', function() {
});
});
});

describe('with a spreadsheet that contains a shared string with an escaped underscore', function() {
before(function() {
var testContext = this;
var workbook = new Excel.Workbook();
return workbook.xlsx.read(fs.createReadStream('./spec/integration/data/shared_string_with_escape.xlsx'))
.then(function() {
testContext.worksheet = workbook.getWorksheet();
});
});

it('should decode the underscore', function() {
const cell = this.worksheet.getCell('A1');
expect(cell.value).to.equal('_x000D_');
});
});
});