Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typing when Typescript is in strict mode #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typing when Typescript is in strict mode #927

wants to merge 1 commit into from

Conversation

lbguilherme
Copy link
Contributor

ExcelJS 1.15.0 causes a type error on any project that depend on it and is in strict mode. Downgrading to 1.14.0 solves the issue.

node_modules/exceljs/index.d.ts(1154,2): error TS7010: 'protect', which lacks return-type annotation, implicitly has an 'any' return type.
node_modules/exceljs/index.d.ts(1155,2): error TS7010: 'unprotect', which lacks return-type annotation, implicitly has an 'any' return type.

This PR fixes the issue.

@eugene1g
Copy link

Good catch!
There is another PR for this at #926 (note that protect returns a Promise as per

exceljs/lib/doc/worksheet.js

Line 593 in d29d2ec

return new PromiseLib.Promise(resolve => {
)

@lbguilherme
Copy link
Contributor Author

Oh, awesome!

I'm closing this in favor of #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbguilherme @eugene1g