reference types for typed functions #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll have to think about this a bit more and check how other engines handle this. I think replacing the FuncAddr and ExternAddr in WasmValue with a newtype (e.g FuncRef and ExternRef) is probably the way to go, as the address should be opaque (the user probably shouldn't be able to pass in their own u32), and the next version will have breaking changes anyways. edit: I changed some things around with WasmValue, I'll come back to this pr to incorporate your example soon, thank you! |
Since 'next' already implemented this feature of this branch, the only meaningful thing remaning is the example, so i updated it to use 'next' types
|
Updated. This PR now only has example of using function references in typed (exported and imported) functions, which I updated to reflect the new types added in next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently neither
Extern::typed_funcnorModuleInstance::exported_funccan have references from "reference types" proposal in their signatures. In this PR i'm adding 2 newtypes for that usage, with from/into underlying u32, but not deref.I briefly considered making
FuncAddrandExternAddrthemselves into newtypes (from aliases), but that would break existing public api.Also includes example with function reference being passed around as a callback