Support the free-threaded build #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tweak comments * Simplify critical sections * avoid resource leak
honnibal
reviewed
Nov 14, 2025
crusaderky
reviewed
Nov 17, 2025
Contributor
There was a problem hiding this comment.
This module would greatly benefit from a RWLock.
Might be worth adding an issue for follow-up.
Contributor
Author
There was a problem hiding this comment.
I'd rather only do that if this shows up as a performance bottleneck.
Contributor
Author
|
I went ahead and added a couple sentences to the readme along with the comments @crusaderky suggested. |
crusaderky
approved these changes
Nov 18, 2025
Contributor
Author
|
OK, let's merge this. Rather than doing a release ASAP with cp314t wheels, we're going to first set up nightly wheels (scientific-python/upload-nightly-action#146) and then set up nightly testing for packages like spaCy further up the stack. Once the full stack is working, we'll do coordinated releases of all the packages including cp314t wheels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the free-threaded build.
I made
BloomFilterandPreshedMapthread-safe under the free-threaded build using critical sections. I also added tests for multithreaded sharing ofBloomFilterandPreshedMap.The other types are not used by spaCy so I don't think it's worth updating them. Ideally I'd document this somewhere, but this project has very minimal docs, so it's not clear where I'd put that.
There's also a few changes included that aren't strictly related to free-threaded support:
bloom.pxdarray.arrayin theBloomFilterserialization. This is substantially faster and makes the multithreaded test I added substantially faster.