fix(checkExact): returns unknown nested fields under a wildcard#1281
Open
fedeci wants to merge 2 commits intoexpress-validator:masterfrom
Open
fix(checkExact): returns unknown nested fields under a wildcard#1281fedeci wants to merge 2 commits intoexpress-validator:masterfrom
fedeci wants to merge 2 commits intoexpress-validator:masterfrom
Conversation
gustavohenke
requested changes
Feb 25, 2024
Member
gustavohenke
left a comment
There was a problem hiding this comment.
Smart way of fixing this, but I'd like to discuss a gotcha with this.
A custom validator can validate any aspect of an object/array, which is an undocumented assumption that this PR breaks. It's arguable whether one could still want this behaviour when there's isArray(), isObject(), among others, nowadays.
Should we keep this behaviour?
If yes, we need to mark fields with any user-specified custom validators (which excludes e.g. isArray()/isObject(), implemented using custom()) as being considered known "as a whole", whereas others are "partially" known.
Either way, we need to document it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1242
To-do list