Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Closed
rhodgkins wants to merge 2 commits into
expressjs:masterfrom
rhodgkins:master
Closed

deps: [email protected]#5404
rhodgkins wants to merge 2 commits into
expressjs:masterfrom
rhodgkins:master

Conversation

@rhodgkins

Copy link
Copy Markdown
Contributor

To allow partitioned option to be used.

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @rhodgkins

@dougwilson

Copy link
Copy Markdown
Contributor

Thank you @rhodgkins ! Would you be willing to add the new features this exposes to our test suite? A PR do our expressjs.com repo to add the new option would also be very appreciated.

@rhodgkins

Copy link
Copy Markdown
Contributor Author

@dougwilson no problem, test added.

@rhodgkins

Copy link
Copy Markdown
Contributor Author

And docs updated expressjs/expressjs.com#1456

@rhodgkins

Copy link
Copy Markdown
Contributor Author

Sorry for the bump @dougwilson but is this ok now let me know if you need anything else. Thanks

@jitenderjayalwal

jitenderjayalwal commented Feb 14, 2024

Copy link
Copy Markdown

Any ETA of getting it merged? We need support of partitioned cookie in our project. @dougwilson

@dougwilson

Copy link
Copy Markdown
Contributor

Hello, the Express project is doing a bit of regrouping is all. We will begin to work on a new version roll out soon.

@1finedev

1finedev commented Mar 3, 2024

Copy link
Copy Markdown

Any luck with the progress on this, we cannot set auth cookies anymore, is there a workaround until this is complete?

@UlisesGascon UlisesGascon requested a review from wesleytodd March 3, 2024 23:46

@sheplu sheplu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1finedev

1finedev commented Mar 4, 2024

Copy link
Copy Markdown

not trying to spam or to be a bother

I noticed this got some attention since yesterday, would this be merged anytime soon or is there a workaround, this is a huge pain point ATM

@dougwilson @UlisesGascon @sheplu

@wesleytodd

Copy link
Copy Markdown
Member

Hey @1finedev, no worries about spamming, but also no need to ping individual contributors. Most of us are following all these repos for all activity, so the ping doesn't help. We are mostly done with the regrouping and landed our first release last week.

I will look at this one now, but my first question for @UlisesGascon is if there was a reason we did not land this before the last release. Was it just overlooked? I am unclear why we wouldn't have just merged if it was all good previously so just want to make sure we were not missing something.

@1finedev

Copy link
Copy Markdown

Hi again, please is there any chance this can be merged. Thanks

@wesleytodd

Copy link
Copy Markdown
Member

Ah sorry I was supposed to reply here and forgot. So we will be working toward another release, but for the time being you can install the already published cookie package and use it instead of the bundled version from the express package itself.

@UlisesGascon UlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will amend the History.md when merging this change, I will land this next Monday, and then it will be included in the next release (no date yet)

@UlisesGascon UlisesGascon added semver-patch This change is a semver patch and removed needs tests labels Mar 14, 2024
@rhodgkins

Copy link
Copy Markdown
Contributor Author

@UlisesGascon has this gone in any of the recent releases? I couldn't see anything in the release notes so thought I'd check...

@rhodgkins

Copy link
Copy Markdown
Contributor Author

Ah ignore me, it's in History.md but wasn't in the notes on the release page.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants