fix: async error handling in view rendering #6486
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Fix async error handling in view rendering
This PR addresses an issue with error handling in the tryRender function related to async/await operations. The original implementation only properly handled synchronous errors, while errors occurring asynchronously in the view.render process could be missed.
The fix properly wraps the callback with explicit error handling to ensure both sync and async errors are caught and properly propagated to the calling function.
Changes: