Use environment variables for tool paths instead of hardcoded#3
Open
snacsnoc wants to merge 3 commits into
Open
Use environment variables for tool paths instead of hardcoded#3snacsnoc wants to merge 3 commits into
snacsnoc wants to merge 3 commits into
Conversation
aa6dd80 to
c7ecd82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Makefiles to replace hardcoded definitions of the compiler (
gcc), linker (ld), archiver (ar), and ranlib (ranlib) with conditional assignments. This change allows users to override these tools via environment variables:Out of the box, Buzz OS was not buildable for me (
gccdefaults to clang on Mac OS for example). Since I'm on arm64, I had to use a cross compiler./home/eylon/makefilenow createsUSR_FILES_DIR(usr/file) by default when building the filesystem image. Previously, the build would fail when this directory didn't exist.It appears you prefer to use curly brackets {} for variable assignments instead of regular parenthesis so I tried to keep the same style.