Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove isExtendingEslintConfig variable on eject #9558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove isExtendingEslintConfig variable on eject #9558

wants to merge 1 commit into from

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented Aug 28, 2020 •
edited
Loading

The part of webpack config that use isExtendingEslintConfig will be removed on eject, the variable itself hasn't been removed yet. This PR makes the variable to be removed on eject as well.

The code block that use this variable:

// @remove-on-eject-begin
ignore: isExtendingEslintConfig,
baseConfig: isExtendingEslintConfig
  ? undefined
  : {
      extends: [require.resolve('eslint-config-react-app')],
    },
useEslintrc: isExtendingEslintConfig,
// @remove-on-eject-end

@mrmckeb
Copy link
Contributor

mrmckeb commented Sep 12, 2020

Hi @lukyth, thanks for the PR. Good news, we're actually removing this feature in the next release.

This will be resolved in #9587 :)

Thanks for your time! This would have been a great candidate had we not planned to remove the flag.

@mrmckeb mrmckeb closed this Sep 12, 2020
@lukyth lukyth deleted the lukyth/remove-eslint-config-eject branch September 13, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukyth @mrmckeb @facebook-github-bot