You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
Motivation
Allow blog authors to display mastodon & bluesky social icons without swizzling. Pre-PR discussion @ #10762
Note that this does not do anything fancy re: generating the actual social URL from anything shorter than an actual URL, since bluesky and mastodon profile links can have ~arbitrary domains, etc.
Test Plan
These are just icons, so no tests added here. Tweaks made to a dogfooding page and the authors file there to make sure the new icons show up. I also did do a sanity check with my own site. 👍
I see some "lint" failures, but it seems it's just complaining about unknown terms ("bluesky", etc). I was about to update project-words.txt (where it seems such things are enumerated), but it's apparently a CI-generated file?
Let me know if there's anything I should do here to address this.
You can run the command yarn lint:spelling:fix locally to update this file!
I've been incrementally resolving the problems reported by the linter(s), most recently prettier formatting. However, it looks like I've updated the PR more times than github likes before it's forcing a maintainer's approval to re-run those workflows again. 👉👈
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Allow blog authors to display mastodon & bluesky social icons without swizzling. Pre-PR discussion @ #10762
Note that this does not do anything fancy re: generating the actual social URL from anything shorter than an actual URL, since bluesky and mastodon profile links can have ~arbitrary domains, etc.
Test Plan
These are just icons, so no tests added here. Tweaks made to a dogfooding page and the authors file there to make sure the new icons show up. I also did do a sanity check with my own site. 👍
Test links
Deploy preview: https://deploy-preview-10764--docusaurus-2.netlify.app/tests/blog