Update plot.py #2523
Update plot.py #2523
Conversation
Removed depreciated/unnecessary datetime conversion
|
Hi @tomthepeach! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Could you please provide some example plots from your branch to validate that the functionality is still working as intended, thanks! |
|
|
|
This is using my fork built locally in a venv |
|
This solves issue #2492 |
|
@tcuongd Ok to merge? |
tcuongd
left a comment
There was a problem hiding this comment.
Thanks for this and sorry for the long review lag.
an extension of facebook#2523, removed remaining instances of the depreciated and unnecessary use of .dt.to_pydatetime()
Removed depreciated/unnecessary datetime conversion