Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 781b678

Browse files
gnoffgnoff
committed
[Fiber] Disable comments as containers in OSS (#32250)
3 years ago we partially disabled comment nodes as valid containers. Some unflagged support was left in due to legacy APIs like `unmountComponentAtNode` and `unstable_renderSubtreeIntoContainer` but these were since removed in React 19. This update flags the remaining uses of comments as containers. DiffTrain build for [0605cd9](0605cd9)
1 parent 3f18106 commit 781b678

23 files changed

+432
-706
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.1.0-native-fb-8bda7155-20250204
1+
19.1.0-native-fb-0605cd9f-20250204

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<ff794dbb4124d92d30a18466f5cb2845>>
10+
* @generated SignedSource<<4dfff11e19522d38d86c81449e821a88>>
1111
*/
1212

1313
"use strict";
@@ -428,5 +428,5 @@ __DEV__ &&
428428
exports.useFormStatus = function () {
429429
return resolveDispatcher().useHostTransitionStatus();
430430
};
431-
exports.version = "19.1.0-native-fb-8bda7155-20250204";
431+
exports.version = "19.1.0-native-fb-0605cd9f-20250204";
432432
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6c3c15356f44e521258bc6b36c04e239>>
10+
* @generated SignedSource<<38a95bc22688e5b76bf3df1031c10569>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-8bda7155-20250204";
206+
exports.version = "19.1.0-native-fb-0605cd9f-20250204";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<6c3c15356f44e521258bc6b36c04e239>>
10+
* @generated SignedSource<<38a95bc22688e5b76bf3df1031c10569>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.1.0-native-fb-8bda7155-20250204";
206+
exports.version = "19.1.0-native-fb-0605cd9f-20250204";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 51 additions & 102 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bc893b40f5241ccc5739e11d06773023>>
10+
* @generated SignedSource<<97008c538e5b8f1fb99d5ffc107ddbb3>>
1111
*/
1212

1313
/*
@@ -454,11 +454,7 @@ __DEV__ &&
454454
break;
455455
default:
456456
if (
457-
((nextRootInstance =
458-
8 === nextRootContext
459-
? nextRootInstance.parentNode
460-
: nextRootInstance),
461-
(nextRootContext = nextRootInstance.tagName),
457+
((nextRootContext = nextRootInstance.tagName),
462458
(nextRootInstance = nextRootInstance.namespaceURI))
463459
)
464460
(nextRootInstance = getOwnHostContext(nextRootInstance)),
@@ -11589,48 +11585,31 @@ __DEV__ &&
1158911585
function insertOrAppendPlacementNodeIntoContainer(node, before, parent) {
1159011586
var tag = node.tag;
1159111587
if (5 === tag || 6 === tag)
11592-
if (((node = node.stateNode), before)) {
11593-
switch (parent.nodeType) {
11594-
case 8:
11595-
parent = parent.parentNode;
11596-
break;
11597-
case 9:
11598-
parent = parent.body;
11599-
break;
11600-
default:
11601-
parent =
11602-
"HTML" === parent.nodeName ? parent.ownerDocument.body : parent;
11603-
}
11604-
supportsMoveBefore
11605-
? parent.moveBefore(node, before)
11606-
: parent.insertBefore(node, before);
11607-
} else
11608-
a: {
11609-
before = parent;
11610-
switch (before.nodeType) {
11611-
case 8:
11612-
parent = before.parentNode;
11613-
supportsMoveBefore
11614-
? parent.moveBefore(node, before)
11615-
: parent.insertBefore(node, before);
11616-
break a;
11617-
case 9:
11618-
parent = before.body;
11619-
break;
11620-
default:
11621-
parent =
11622-
"HTML" === before.nodeName
11588+
(node = node.stateNode),
11589+
before
11590+
? ((parent =
11591+
9 === parent.nodeType
11592+
? parent.body
11593+
: "HTML" === parent.nodeName
11594+
? parent.ownerDocument.body
11595+
: parent),
11596+
supportsMoveBefore
11597+
? parent.moveBefore(node, before)
11598+
: parent.insertBefore(node, before))
11599+
: ((before = parent),
11600+
(parent =
11601+
9 === before.nodeType
11602+
? before.body
11603+
: "HTML" === before.nodeName
1162311604
? before.ownerDocument.body
11624-
: before;
11625-
}
11626-
supportsMoveBefore
11627-
? parent.moveBefore(node, null)
11628-
: parent.appendChild(node);
11629-
before = before._reactRootContainer;
11630-
(null !== before && void 0 !== before) ||
11631-
null !== parent.onclick ||
11632-
(parent.onclick = noop$1);
11633-
}
11605+
: before),
11606+
supportsMoveBefore
11607+
? parent.moveBefore(node, null)
11608+
: parent.appendChild(node),
11609+
(before = before._reactRootContainer),
11610+
(null !== before && void 0 !== before) ||
11611+
null !== parent.onclick ||
11612+
(parent.onclick = noop$1));
1163411613
else if (
1163511614
4 !== tag &&
1163611615
(27 === tag &&
@@ -12225,26 +12204,14 @@ __DEV__ &&
1222512204
null !== hostParent &&
1222612205
(hostParentIsContainer
1222712206
? ((nearestMountedAncestor = hostParent),
12228-
(deletedFiber = deletedFiber.stateNode),
12229-
8 === nearestMountedAncestor.nodeType
12230-
? clearSuspenseBoundary(
12231-
nearestMountedAncestor.parentNode,
12232-
deletedFiber
12233-
)
12234-
: 9 === nearestMountedAncestor.nodeType
12235-
? clearSuspenseBoundary(
12236-
nearestMountedAncestor.body,
12237-
deletedFiber
12238-
)
12207+
clearSuspenseBoundary(
12208+
9 === nearestMountedAncestor.nodeType
12209+
? nearestMountedAncestor.body
1223912210
: "HTML" === nearestMountedAncestor.nodeName
12240-
? clearSuspenseBoundary(
12241-
nearestMountedAncestor.ownerDocument.body,
12242-
deletedFiber
12243-
)
12244-
: clearSuspenseBoundary(
12245-
nearestMountedAncestor,
12246-
deletedFiber
12247-
),
12211+
? nearestMountedAncestor.ownerDocument.body
12212+
: nearestMountedAncestor,
12213+
deletedFiber.stateNode
12214+
),
1224812215
retryIfBlockedOn(nearestMountedAncestor))
1224912216
: clearSuspenseBoundary(hostParent, deletedFiber.stateNode));
1225012217
break;
@@ -17535,23 +17502,15 @@ __DEV__ &&
1753517502
var nodeTag = targetInst$jscomp$0.tag;
1753617503
if (3 === nodeTag || 4 === nodeTag) {
1753717504
var container = targetInst$jscomp$0.stateNode.containerInfo;
17538-
if (
17539-
container === targetContainer ||
17540-
(8 === container.nodeType &&
17541-
container.parentNode === targetContainer)
17542-
)
17543-
break;
17505+
if (container === targetContainer) break;
1754417506
if (4 === nodeTag)
1754517507
for (nodeTag = targetInst$jscomp$0.return; null !== nodeTag; ) {
1754617508
var grandTag = nodeTag.tag;
17547-
if (3 === grandTag || 4 === grandTag)
17548-
if (
17549-
((grandTag = nodeTag.stateNode.containerInfo),
17550-
grandTag === targetContainer ||
17551-
(8 === grandTag.nodeType &&
17552-
grandTag.parentNode === targetContainer))
17553-
)
17554-
return;
17509+
if (
17510+
(3 === grandTag || 4 === grandTag) &&
17511+
nodeTag.stateNode.containerInfo === targetContainer
17512+
)
17513+
return;
1755517514
nodeTag = nodeTag.return;
1755617515
}
1755717516
for (; null !== container; ) {
@@ -20359,20 +20318,12 @@ __DEV__ &&
2035920318
parentInstance.removeChild(child);
2036020319
}
2036120320
function removeChildFromContainer(container, child) {
20362-
switch (container.nodeType) {
20363-
case 8:
20364-
container = container.parentNode;
20365-
break;
20366-
case 9:
20367-
container = container.body;
20368-
break;
20369-
default:
20370-
container =
20371-
"HTML" === container.nodeName
20372-
? container.ownerDocument.body
20373-
: container;
20374-
}
20375-
container.removeChild(child);
20321+
(9 === container.nodeType
20322+
? container.body
20323+
: "HTML" === container.nodeName
20324+
? container.ownerDocument.body
20325+
: container
20326+
).removeChild(child);
2037620327
}
2037720328
function clearSuspenseBoundary(parentInstance, suspenseInstance) {
2037820329
var node = suspenseInstance,
@@ -26052,11 +26003,11 @@ __DEV__ &&
2605226003
};
2605326004
(function () {
2605426005
var isomorphicReactPackageVersion = React.version;
26055-
if ("19.1.0-native-fb-8bda7155-20250204" !== isomorphicReactPackageVersion)
26006+
if ("19.1.0-native-fb-0605cd9f-20250204" !== isomorphicReactPackageVersion)
2605626007
throw Error(
2605726008
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2605826009
(isomorphicReactPackageVersion +
26059-
"\n - react-dom: 19.1.0-native-fb-8bda7155-20250204\nLearn more: https://react.dev/warnings/version-mismatch")
26010+
"\n - react-dom: 19.1.0-native-fb-0605cd9f-20250204\nLearn more: https://react.dev/warnings/version-mismatch")
2606026011
);
2606126012
})();
2606226013
("function" === typeof Map &&
@@ -26093,10 +26044,10 @@ __DEV__ &&
2609326044
!(function () {
2609426045
var internals = {
2609526046
bundleType: 1,
26096-
version: "19.1.0-native-fb-8bda7155-20250204",
26047+
version: "19.1.0-native-fb-0605cd9f-20250204",
2609726048
rendererPackageName: "react-dom",
2609826049
currentDispatcherRef: ReactSharedInternals,
26099-
reconcilerVersion: "19.1.0-native-fb-8bda7155-20250204"
26050+
reconcilerVersion: "19.1.0-native-fb-0605cd9f-20250204"
2610026051
};
2610126052
internals.overrideHookState = overrideHookState;
2610226053
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -26179,9 +26130,7 @@ __DEV__ &&
2617926130
null
2618026131
);
2618126132
container[internalContainerInstanceKey] = options.current;
26182-
listenToAllSupportedEvents(
26183-
8 === container.nodeType ? container.parentNode : container
26184-
);
26133+
listenToAllSupportedEvents(container);
2618526134
return new ReactDOMRoot(options);
2618626135
};
2618726136
exports.hydrateRoot = function (container, initialChildren, options) {
@@ -26242,5 +26191,5 @@ __DEV__ &&
2624226191
listenToAllSupportedEvents(container);
2624326192
return new ReactDOMHydrationRoot(initialChildren);
2624426193
};
26245-
exports.version = "19.1.0-native-fb-8bda7155-20250204";
26194+
exports.version = "19.1.0-native-fb-0605cd9f-20250204";
2624626195
})();

0 commit comments

Comments
 (0)