Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix suspense replaying forwardRefs #26420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix suspense replaying forwardRefs #26420

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dc1ae2
Fix suspense replaying forwardRefs (#26385)
hansottowirtz Mar 17, 2023
e1d6fe7
Add test for use hook with forwardRef
hansottowirtz Mar 17, 2023
e829146
Add test for forwardRefs second arg with use
hansottowirtz Mar 17, 2023
d111aa9
Fix suspense replaying forwardRefs with correct secondArg
hansottowirtz Apr 1, 2023
ec456e3
Improve suspense replaying forwardRef test
hansottowirtz Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Improve suspense replaying forwardRef test
  • Loading branch information
@hansottowirtz
hansottowirtz committed Apr 1, 2023
commit ec456e300eba44da88a03334533a8b01a69a0b52
6 changes: 4 additions & 2 deletions packages/react-reconciler/src/__tests__/ReactUse-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1478,8 +1478,10 @@ describe('ReactUse', () => {
const promiseB = Promise.resolve('B');
const promiseC = Promise.resolve('C');

const refSymbol = {};

const Async = React.forwardRef((props, ref) => {
React.useImperativeHandle(ref, () => ({}));
React.useImperativeHandle(ref, () => refSymbol);
const text = use(promiseA) + use(promiseB) + use(promiseC);
return <Text text={text} />;
});
Expand All @@ -1505,6 +1507,6 @@ describe('ReactUse', () => {
});
assertLog(['ABC']);
expect(root).toMatchRenderedOutput('ABC');
expect(_ref).toBeDefined();
expect(_ref).toBe(refSymbol);
});
});