Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement public instances for text nodes in Fabric #26516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Implement public instances for text nodes in Fabric #26516

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd56e2a
Define type alias for InternalInstanceHandle
rubennorte Mar 30, 2023
c94437c
Create public instances for text nodes lazily
rubennorte Mar 30, 2023
490bc08
Add unit tests
rubennorte Mar 30, 2023
6f9771e
Fix test for getNodeFromInternalInstanceHandle
rubennorte Mar 30, 2023
bd6c6e9
Add definitions in ReactNativeTypes
rubennorte Mar 30, 2023
c9ac0e3
Fix lint/prettier
rubennorte Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Define type alias for InternalInstanceHandle
  • Loading branch information
@rubennorte
rubennorte committed Mar 30, 2023
commit dd56e2a1c436fc714718bc588a5518e4d337eaab
22 changes: 14 additions & 8 deletions packages/react-native-renderer/src/ReactFabricHostConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,22 @@ const {get: getViewConfigForType} = ReactNativeViewConfigRegistry;
// This means that they never overlap.
let nextReactTag = 2;

type InternalInstanceHandle = Object;
type Node = Object;
export type Type = string;
export type Props = Object;
export type Instance = {
// Reference to the shadow node.
node: Node,
// This object is shared by all the clones of the instance.
// We use it to access their shared public instance (exposed through refs)
// and to access its committed state for events, etc.
canonical: {
nativeTag: number,
viewConfig: ViewConfig,
currentProps: Props,
// Reference to the React handle (the fiber)
internalInstanceHandle: Object,
internalInstanceHandle: InternalInstanceHandle,
// Exposed through refs.
publicInstance: PublicInstance,
},
Expand Down Expand Up @@ -115,7 +119,7 @@ export function createInstance(
props: Props,
rootContainerInstance: Container,
hostContext: HostContext,
internalInstanceHandle: Object,
internalInstanceHandle: InternalInstanceHandle,
): Instance {
const tag = nextReactTag;
nextReactTag += 2;
Expand Down Expand Up @@ -162,7 +166,7 @@ export function createTextInstance(
text: string,
rootContainerInstance: Container,
hostContext: HostContext,
internalInstanceHandle: Object,
internalInstanceHandle: InternalInstanceHandle,
): TextInstance {
if (__DEV__) {
if (!hostContext.isInAParentText) {
Expand Down Expand Up @@ -240,7 +244,7 @@ export function getPublicInstance(instance: Instance): null | PublicInstance {
}

export function getPublicInstanceFromInternalInstanceHandle(
internalInstanceHandle: Object,
internalInstanceHandle: InternalInstanceHandle,
): null | PublicInstance {
const instance: Instance = internalInstanceHandle.stateNode;
return getPublicInstance(instance);
Expand Down Expand Up @@ -321,7 +325,7 @@ export function cloneInstance(
type: string,
oldProps: Props,
newProps: Props,
internalInstanceHandle: Object,
internalInstanceHandle: InternalInstanceHandle,
keepChildren: boolean,
recyclableInstance: null | Instance,
): Instance {
Expand Down Expand Up @@ -350,7 +354,7 @@ export function cloneHiddenInstance(
instance: Instance,
type: string,
props: Props,
internalInstanceHandle: Object,
internalInstanceHandle: InternalInstanceHandle,
): Instance {
const viewConfig = instance.canonical.viewConfig;
const node = instance.node;
Expand All @@ -367,7 +371,7 @@ export function cloneHiddenInstance(
export function cloneHiddenTextInstance(
instance: Instance,
text: string,
internalInstanceHandle: Object,
internalInstanceHandle: InternalInstanceHandle,
): TextInstance {
throw new Error('Not yet implemented.');
}
Expand Down Expand Up @@ -399,7 +403,9 @@ export function getInstanceFromNode(node: any): empty {
throw new Error('Not yet implemented.');
}

export function beforeActiveInstanceBlur(internalInstanceHandle: Object) {
export function beforeActiveInstanceBlur(
internalInstanceHandle: InternalInstanceHandle,
) {
// noop
}

Expand Down