[Flight] Ship DEV-only enableServerComponentLogs flag in Stable/Canary#30847
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eps1lon
left a comment
There was a problem hiding this comment.
Should we enable it based on __VARIANT__ in www-dynamic so that we have some coverage for the old behavior until we clean it up?
I thought it was still double logging on the server terminal in Next.js so I'd like to double check.
I was just going to clean it up pretty soon after anyway since it's on everywhere. |
|
Makes sense. It's been on in vercel.com for a while now. |
|
Can bring up for further discussion if needed but this has a simple opt-out so it's not really that invasive. |
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-7771d3a7-20240827` to `19.0.0-rc-94e652d5-20240912`** [diff facebook/react@7771d3a7...94e652d5](facebook/react@7771d3a...94e652d) <details> <summary>React upstream changes</summary> - facebook/react#30952 - facebook/react#30950 - facebook/react#30946 - facebook/react#30934 - facebook/react#30947 - facebook/react#30945 - facebook/react#30938 - facebook/react#30936 - facebook/react#30879 - facebook/react#30888 - facebook/react#30931 - facebook/react#30930 - facebook/react#30832 - facebook/react#30929 - facebook/react#30926 - facebook/react#30925 - facebook/react#30905 - facebook/react#30900 - facebook/react#30910 - facebook/react#30906 - facebook/react#30899 - facebook/react#30919 - facebook/react#30708 - facebook/react#30907 - facebook/react#30897 - facebook/react#30896 - facebook/react#30895 - facebook/react#30887 - facebook/react#30889 - facebook/react#30893 - facebook/react#30892 - facebook/react#30891 - facebook/react#30882 - facebook/react#30881 - facebook/react#30870 - facebook/react#30849 - facebook/react#30878 - facebook/react#30865 - facebook/react#30869 - facebook/react#30875 - facebook/react#30800 - facebook/react#30762 - facebook/react#30831 - facebook/react#30866 - facebook/react#30853 - facebook/react#30850 - facebook/react#30847 - facebook/react#30842 - facebook/react#30837 - facebook/react#30848 - facebook/react#30844 - facebook/react#30839 - facebook/react#30802 - facebook/react#30841 - facebook/react#30827 - facebook/react#30826 - facebook/react#30825 - facebook/react#30824 - facebook/react#30840 - facebook/react#30838 - facebook/react#30836 - facebook/react#30819 - facebook/react#30816 - facebook/react#30814 - facebook/react#30813 - facebook/react#30812 - facebook/react#30811 </details> --------- Co-authored-by: vercel-release-bot <[email protected]>
To recap. This only affects DEV and RSC. It patches console on the server in DEV (similar to how React DevTools already does and what we did for the double logging). Then replays those logs with a
[Server]badge on the client so you don't need a server terminal open.This has been on for over 6 months now in our experimental channel and we've had a lot of coverage in Next.js due to various experimental flags like taint and ppr.
It's non-invasive in that even if something throws we just serialize that as an unknown value.
The main feedback we've gotten was:
replayConsoleoption to either opt-in or out.We've reached a good spot now I think.
These are better with
enableOwnerStacksbut that's a separate track and not needed.The only thing to document here, other than maybe that we're doing it, is the
replayConsoleoption but that's part of the RSC renderers that themselves are not documented so nowhere to document it.