[sync] Fix noop for xplat#33214
Merged
Merged
Conversation
|
Comparing: 203df2c...f50ac1f Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
approved these changes
May 15, 2025
This was referenced May 15, 2025
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noop detection for xplat syncs broke because
eslint-plugin-react-hooksuses versions like:0.0.0-experimental-d85f86cf-20250514But xplat expects them to be of the form:
19.2.0-native-fb-63d664b2-20250514This PR fixes the noop by ignoring
eslint-plugin-react-hooks/package.jsonchanges. This means we won't create a sync if only that package.json changes, but that should be rare and we can follow up with better detection if needed.Example failed action:
I believe the regression was caused by #33104