[Reconciler] Set ProfileMode for Host Root Fiber by default in dev #34432
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Sep 9, 2025
sebmarkbage
reviewed
Sep 9, 2025
| // Always collect profile timings when DevTools are present. | ||
| // This enables DevTools to start capturing timing at any point– | ||
| // Without some nodes in the tree having empty base times. | ||
| if (__DEV__ || (enableProfilerTimer && isDevToolsPresent)) { |
There was a problem hiding this comment.
It would be a breaking change but my preference would be that this is only on for DEV and not if isDevToolsPresent. Since otherwise if I have a profiling build and I have devtools installed, but my colleague doesn't, it can be confusing why it doesn't work. Whereas if it's always <Profiler> that opt-in to profiling builds then I'd have to add it and then my colleague would see it too.
|
Comparing: 0c813c5...e3a6386 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
b7a663c to
e3a6386
Compare
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Sep 14, 2025
…acebook#34432) Requiring DevTools to be present for dev builds seems like an overkill, let's enable the instrumentation by default. Nothing changes for profiling or production artifacts. DiffTrain build for [0e10ee9](facebook@0e10ee9)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Sep 14, 2025
…acebook#34432) Requiring DevTools to be present for dev builds seems like an overkill, let's enable the instrumentation by default. Nothing changes for profiling or production artifacts. DiffTrain build for [0e10ee9](facebook@0e10ee9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring DevTools to be present for dev builds seems like an overkill, let's enable the instrumentation by default.
Nothing changes for profiling or production artifacts.