Add Hermes Root API in all other versions of Hermes #51082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Build JSI with C++17. Changelog: [Internal] Reviewed By: dannysu Differential Revision: D72079417
Summary: Add UUID struct to JSI. This will be used in the incoming changes, such as identifying JSI interfaces and storing custom runtime data. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D71826382
Summary: Add JSI castInterface API. This provides a structured way to provide optional APIs that may or may not be supported in all engines. Every interface will have its own set of APIs. For instance, Hermes will provide an interface (`IHermes`) containing Hermes-specific APIs. In the future, an interface may be created to expose optional APIs. A runtime will inherit the interfaces of which the APIs are supported by the runtime. Users who want to access a specific API may call castInterface with the UUID of interface containing the API. For backwards compatibility, the current `jsi::Runtime` will remain as an object, and its functionalities will not be described by an interface. However, this may be revisited later. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D68964360
Summary: After introducing the interfaces, runtime should be managed through a shared pointer instead of a unique pointer. This diff will change the usage in JSI testlib. Later diffs will actually change the HermesRuntime usages. Reviewed By: lavenzg Differential Revision: D70113190
Summary: Introduces the `IHermesRootAPI` interface and a class implementation. This root API will contain the previously static methods on `HermesRuntime`. The root API will serve as an entry point for users to create the Hermes runtime and invoke methods that do not necessarily require a runtime. Diff also moves all usages of the static methods on `HermesRuntime` to getting the methods from the root API. Multiple places are depending on Hermes, Hermes snapshot, and Shermes, so this diff will also update all of these verions of Hermes at once. Differential Revision: D71132855
|
This pull request was exported from Phabricator. Differential Revision: D71132855 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces the
IHermesRootAPIinterface and a class implementation.This root API will contain the previously static methods on
HermesRuntime.The root API will serve as an entry point for users to create the Hermes
runtime and invoke methods that do not necessarily require a runtime.
Diff also moves all usages of the static methods on
HermesRuntimetogetting the methods from the root API.
Multiple places are depending on Hermes, Hermes snapshot, and Shermes,
so this diff will also update all of these verions of Hermes at once.
Differential Revision: D71132855