fix(types): Reference global.d.ts using path not types
#51104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@philIip Let me know if you can reproduce the issue, or if there is something I can do. I thought I can ignore the lint by the ignore comment, but sadly that doesn't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After #49516 TSC would not find the global types.
Types reference expect a package name but was given a path to a declaration.
TS doc: https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-path-
This PR changes
typestopathto fix the issue.dtslintfails withno-bad-referencerule, but the../srclives in the same package inreact-nativepackage.Changelog:
[GENERAL] [FIXED] - Reference
global.d.tsusingpathso they can be resolved by TSCTest Plan:
Before the change with current RN 0.79.2 TSC would fail on resolving the global types (example from Sentry RN SDK build):
After the change to path TSC finds the global types.
Using TSC Version 4.9.5