Remove un-needed vector utilities#282
Merged
Merged
Conversation
bitwalker
reviewed
May 9, 2024
bitwalker
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Seems like they've improved optimizations on vec! a bit, nice that we can just lean on that here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #277 and in the process removes
group_vector_elements()andFieldElement::zeroed_vector()functions.After doing some benchmarking, it seems like the impact of removing these functions is negligible (or maybe even non-existent).