remove .pin_memory() in obj_pos of SAM2Base to resolve and error in MPS#495
Merged
ronghanghu merged 1 commit intoDec 16, 2024
Conversation
…r in MPS In this PR, we remove `.pin_memory()` in `obj_pos` of `SAM2Base` to resolve and error in MPS. Investigations show that `.pin_memory()` causes an error of `Attempted to set the storage of a tensor on device "cpu" to a storage on different device "mps:0"`, as originally reported in facebookresearch#487. (close facebookresearch#487)
chayryali
approved these changes
Dec 15, 2024
mahmoudzaouali
pushed a commit
to mahmoudzaouali/sam2
that referenced
this pull request
Jul 31, 2025
…r in MPS (facebookresearch#495) In this PR, we remove `.pin_memory()` in `obj_pos` of `SAM2Base` to resolve and error in MPS. Investigations show that `.pin_memory()` causes an error of `Attempted to set the storage of a tensor on device "cpu" to a storage on different device "mps:0"`, as originally reported in facebookresearch#487. (close facebookresearch#487)
maximuswatkins
pushed a commit
to owen24819/CellSam2
that referenced
this pull request
May 25, 2026
…r in MPS (facebookresearch#495) In this PR, we remove `.pin_memory()` in `obj_pos` of `SAM2Base` to resolve and error in MPS. Investigations show that `.pin_memory()` causes an error of `Attempted to set the storage of a tensor on device "cpu" to a storage on different device "mps:0"`, as originally reported in facebookresearch#487. (close facebookresearch#487)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we remove
.pin_memory()inobj_posofSAM2Baseto resolve and error in MPS. Investigations show that.pin_memory()causes an error ofAttempted to set the storage of a tensor on device "cpu" to a storage on different device "mps:0", as originally reported in #487.(close #487)