Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Improve performance of converting to C# List #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2022
Merged

feat: Improve performance of converting to C# List #207

merged 2 commits into from
Apr 5, 2022

Conversation

LeeDongGeon1996
Copy link
Member

@LeeDongGeon1996 LeeDongGeon1996 commented Apr 4, 2022 •
edited
Loading

Description

  • Improve performance of converting to C# List.
  • Approx. 12% improvement in runnning time.

Benchmarks

# Before
------------------------------------------------------ benchmark: 1 tests ------------------------------------------------------
Name (time in ms)                      Min       Max      Mean   StdDev    Median      IQR  Outliers     OPS  Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------
test_benchmark_hurst_longlong     330.1131  426.2715  351.0660  42.0999  332.5940  27.9184       1;1  2.8485       5           1
--------------------------------------------------------------------------------------------------------------------------------

# After
------------------------------------------------------ benchmark: 1 tests ------------------------------------------------------
Name (time in ms)                      Min       Max      Mean   StdDev    Median      IQR  Outliers     OPS  Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------
test_benchmark_hurst_longlong     280.6001  379.0518  300.7573  43.7718  281.3770  25.6203       1;1  3.3249       5           1
--------------------------------------------------------------------------------------------------------------------------------

References

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review April 4, 2022 17:26
DaveSkender
DaveSkender approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

@LeeDongGeon1996 LeeDongGeon1996 merged commit f7c2587 into facioquo:main Apr 5, 2022
@LeeDongGeon1996 LeeDongGeon1996 deleted the feat/improve-cslist-perf branch April 5, 2022 05:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DaveSkender DaveSkender DaveSkender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeeDongGeon1996 @DaveSkender