Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Improve performance of converting to C# List #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2022
Merged

feat: Improve performance of converting to C# List #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0e7328
Improve converting to cslist performance
LeeDongGeon1996 Apr 4, 2022
965ffe2
Add benchmark for large nums of quotes
LeeDongGeon1996 Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions benchmarks/test_benchmark_indicators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ def test_benchmark_ht_trendline(benchmark, quotes):

def test_benchmark_hurst(benchmark, quotes):
benchmark(indicators.get_hurst, quotes)

def test_benchmark_hurst_longlong(benchmark, longish_quotes):
benchmark(indicators.get_hurst, longish_quotes+longish_quotes)

def test_benchmark_ichimoku(benchmark, quotes):
benchmark(indicators.get_ichimoku, quotes)
Expand Down
12 changes: 7 additions & 5 deletions stock_indicators/_cstypes/list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
from collections import deque

from stock_indicators._cslib import CsList


class List:
"""
Class for converting Python's iterator type into C#'s `System.Collections.Generic.List` class.
Expand Down Expand Up @@ -29,8 +32,7 @@ class List:
"""

def __new__(cls, generic, sequence) -> CsList:
clist = CsList[generic]()
for i in sequence:
clist.Add(i)

return clist
cs_list = CsList[generic]()
deque(map(cs_list.Add, sequence), maxlen=0)

return cs_list