Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Polish translation for docs/pl/docs/help-fastapi.md#10121

Merged
tiangolo merged 22 commits into
fastapi:masterfrom
romabozhanovgithub:polish-translation_help-fastapi
Sep 22, 2023
Merged

🌐 Add Polish translation for docs/pl/docs/help-fastapi.md#10121
tiangolo merged 22 commits into
fastapi:masterfrom
romabozhanovgithub:polish-translation_help-fastapi

Conversation

@romabozhanovgithub

Copy link
Copy Markdown
Contributor

Relates to #9195

This PR is a translation of docs/pl/docs/help-fastapi.md

This is my first PR to this repository. I would appreciate a code review. Please let me know if it has any problems.

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 52aa099 at: https://2c51a7d2.fastapitiangolo.pages.dev

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 679878a at: https://1e5494a5.fastapitiangolo.pages.dev

@isulim isulim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of translation is ok, but I have some suggestions.

Większość tłumaczenia jest ok, ale mam trochę propozycji.

Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
@romabozhanovgithub

romabozhanovgithub commented Aug 31, 2023

Copy link
Copy Markdown
Contributor Author

@isulim Thanks for your review, really appreciate

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 026faf5 at: https://fc058b53.fastapitiangolo.pages.dev

@isulim

isulim commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Hello @tiangolo
Why does smokeshow/coverage fail on file tests/test_openapi_examples.py?
I never changed this file.

@romabozhanovgithub

Copy link
Copy Markdown
Contributor Author

Hello @tiangolo Why does smokeshow/coverage fail on file tests/test_openapi_examples.py? I never changed this file.

Same here

@tiangolo

tiangolo commented Sep 1, 2023

Copy link
Copy Markdown
Member

It seems it was a line in a dummy test I left uncovered and I probably didn't notice while Smokeshow was having errors. But now I added it, and updating the branch here should solve it. 🤓

@tiangolo

tiangolo commented Sep 1, 2023

Copy link
Copy Markdown
Member

📝 Docs preview for commit 5c4fcab at: https://ae496c77.fastapitiangolo.pages.dev

@tiangolo tiangolo added awaiting-review lang-pl Polish translations labels Sep 2, 2023
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
Comment thread docs/pl/docs/help-fastapi.md Outdated
@romabozhanovgithub

Copy link
Copy Markdown
Contributor Author

@isulim @bluefish6 Thanks for your review and suggestions!

@bluefish6 bluefish6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 6788ebc at: https://e8b63855.fastapitiangolo.pages.dev

@romabozhanovgithub

Copy link
Copy Markdown
Contributor Author

@tiangolo Looks like we have 2 approves there

@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 2d2e711 at: https://17f45cfb.fastapitiangolo.pages.dev

@tiangolo tiangolo changed the title 🌐Add Polish translation for docs/pl/docs/help-fastapi.md 🌐 Add Polish translation for docs/pl/docs/help-fastapi.md Sep 22, 2023
@tiangolo

Copy link
Copy Markdown
Member

Thanks @romabozhanovgithub! 🙇

And thanks for the reviews @bluefish6 and @isulim 🍰

@tiangolo tiangolo merged commit 8924631 into fastapi:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-pl Polish translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants