Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Russian translation for docs/ru/docs/tutorial/security/simple-oauth2.md#10599

Merged
alejsdev merged 11 commits into
fastapi:masterfrom
AlertRED:simple-oauth2-russian-translation
Dec 10, 2024
Merged

🌐 Add Russian translation for docs/ru/docs/tutorial/security/simple-oauth2.md#10599
alejsdev merged 11 commits into
fastapi:masterfrom
AlertRED:simple-oauth2-russian-translation

Conversation

@AlertRED

@AlertRED AlertRED commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@alejsdev alejsdev added lang-all Translations lang-ru Russian translations awaiting-review labels Jan 8, 2024
@codespearhead

Copy link
Copy Markdown

Do you happen to know three Russian developers you can ask a PR review from? This might help.

@github-actions

Copy link
Copy Markdown
Contributor

Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md
@github-actions

Copy link
Copy Markdown
Contributor

@AlertRED AlertRED requested a review from alv2017 November 25, 2024 13:19
@github-actions

Copy link
Copy Markdown
Contributor


А ваши модели баз данных могут использовать любые другие имена.

Но при авторизации в *эндпоинте* нам необходимо использовать именно эти имена, чтобы соответствовать спецификации (и иметь возможность, например, использовать это во встроенной системе документации API).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Но при авторизации в *эндпоинте* нам необходимо использовать именно эти имена, чтобы соответствовать спецификации (и иметь возможность, например, использовать это во встроенной системе документации API).
Но при авторизации, согласно спецификации, требуется использовать именно эти имена. (Это даст нам возможность, воспользоваться встроенной системой документации API).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alv2017 Только в этом предложении немного изменил ваш вариант

Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
@alv2017

alv2017 commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

@Xewus, @s111d нужна помощь с ревью. Подключайтесь!
👋 😊

@alv2017 alv2017 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дополнительно добавила предложения по улучшению перевода (на твое усмотрение)

@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev

Copy link
Copy Markdown
Member

Hi @AlertRED, I have updated the documentation with the latest syntax for includes.
I will wait for you to review the changes suggested by @alv2017 before merging the PR.
Thanks to both of you for the help! 🚀

Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

@alv2017

alv2017 commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

@alejsdev: Thank you for your help!

@AlertRED: I think we are ready with PR, aren't we?

😃

@github-actions github-actions Bot removed the waiting label Nov 28, 2024
@AlertRED

Copy link
Copy Markdown
Contributor Author

@alejsdev: Thank you for your help!

@AlertRED: I think we are ready with PR, aren't we?

😃

Yes, we are :)

@Xewus Xewus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом, проделанный объём работы большой.

Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
Co-authored-by: Vladislav Kramorenko <[email protected]>
Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
@AlertRED AlertRED requested a review from Xewus November 30, 2024 10:20
@github-actions

Copy link
Copy Markdown
Contributor

@alv2017 alv2017 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У меня возражение по поводу строки 135: scope vs scopes

#10599 (comment)

Comment thread docs/ru/docs/tutorial/security/simple-oauth2.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

@alv2017

alv2017 commented Nov 30, 2024

Copy link
Copy Markdown
Contributor

Проблема решена, у меня никаких возражений больше нет 😃

@alejsdev alejsdev merged commit a54e336 into fastapi:master Dec 10, 2024
@alejsdev

Copy link
Copy Markdown
Member

Great! Thanks for your work @AlertRED @Xewus @alv2017 🚀 ✨

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ru Russian translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants