Thanks to visit codestin.com
Credit goes to github.com

Skip to content

✏️ Fix typo in docs/en/docs/alternatives.md#10931

Merged
alejsdev merged 2 commits into
fastapi:masterfrom
s111d:master
Jan 11, 2024
Merged

✏️ Fix typo in docs/en/docs/alternatives.md#10931
alejsdev merged 2 commits into
fastapi:masterfrom
s111d:master

Conversation

@s111d

@s111d s111d commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Pluralize

Pluralize
@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 6cae29a at: https://f13a4dfa.fastapitiangolo.pages.dev

@s111d

s111d commented Jan 10, 2024

Copy link
Copy Markdown
Contributor Author

Also: I'm not sure if its worth attention, but should'n the bullet here be just like "Info" bullets below and not "Note": https://fastapi.tiangolo.com/alternatives/#django-rest-framework
I'm asking because from what I see, creators of something usually go under "Info" section. See here, for example: https://fastapi.tiangolo.com/alternatives/#webargs

@hasansezertasan

hasansezertasan commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Also: I'm not sure if its worth attention, but should'n the bullet here be just like "Info" bullets below and not "Note": https://fastapi.tiangolo.com/alternatives/#django-rest-framework I'm asking because from what I see, creators of something usually go under "Info" section. See here, for example: https://fastapi.tiangolo.com/alternatives/#webargs

I feel you, I think you should make those changes and commit but the documentation looks a bit (quite a bit) personal. So IDK if we have a say in this matter.

Edit: Because it's a bit personal, the author might feel like "it's a note, instead of info..."

@s111d

s111d commented Jan 10, 2024

Copy link
Copy Markdown
Contributor Author

Another thing, same file: "Angular two" – maybe just plainly "Angular 2"? Number of version is usually not spelled.

@alejsdev alejsdev changed the title Fix typo ✏️ Fix typo in docs/en/docs/alternatives.md Jan 11, 2024
@alejsdev alejsdev self-requested a review January 11, 2024 14:07
@alejsdev alejsdev added awaiting-review docs Documentation about how to use FastAPI and removed awaiting-review labels Jan 11, 2024
@tiangolo

Copy link
Copy Markdown
Member

📝 Docs preview for commit 8f9d8fa at: https://7130e85e.fastapitiangolo.pages.dev

@alejsdev alejsdev merged commit c46eba8 into fastapi:master Jan 11, 2024
@alejsdev

Copy link
Copy Markdown
Member

Good catch! Thanks @s111d 🐱

Another thing, same file: "Angular two" – maybe just plainly "Angular 2"? Number of version is usually not spelled.

I agreed with this one and made that change as well.

Thanks for your help too @mirovisionepitech and @hasansezertasan

nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants