📝 Update docs_src/path_params_numeric_validations/tutorial006.py#11478
Merged
Conversation
The size parameter was not appended into the results.
Member
|
📝 Docs preview for commit 4254b2c at: https://dcbd9b93.fastapitiangolo.pages.dev |
The size parameter was not appended to results
The size parameter was not appended to results
Member
|
📝 Docs preview for commit 83684df at: https://7abfa613.fastapitiangolo.pages.dev |
docs_src/path_params_numeric_validations/tutorial006.py
Member
|
📝 Docs preview for commit e31090d at: https://9d7f0a09.fastapitiangolo.pages.dev |
Contributor
|
📝 Docs preview for commit e5695b3 at: https://61df5171.fastapitiangolo.pages.dev |
svlandeg
approved these changes
Aug 28, 2024
svlandeg
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR!
Adding the size parameter to the results makes sense because then at least the body of the function is doing something with this value. Mostly this part of the tutorial is about using the gt and lt annotations in Query, so it doesn't matter much either way, but this edit doesn't hurt 🙂
Thanks again!
Member
|
Cool, thanks @MuhammadAshiqAmeer! ☕ And thanks @svlandeg 🍰 |
Contributor
Author
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
…astapi#11478) Co-authored-by: Sofie Van Landeghem <[email protected]>
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
…astapi#11478) Co-authored-by: Sofie Van Landeghem <[email protected]>
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
…astapi#11478) Co-authored-by: Sofie Van Landeghem <[email protected]>
s-rigaud
pushed a commit
to s-rigaud/fastapi
that referenced
this pull request
Jan 23, 2025
…astapi#11478) Co-authored-by: Sofie Van Landeghem <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The size parameter was not appended into the results.