Thanks to visit codestin.com
Credit goes to github.com

Skip to content

📝 Fix GZipMiddleware example in "Advanced Middlewares"#1150

Closed
niazangels wants to merge 1 commit into
fastapi:masterfrom
niazangels:patch-1
Closed

📝 Fix GZipMiddleware example in "Advanced Middlewares"#1150
niazangels wants to merge 1 commit into
fastapi:masterfrom
niazangels:patch-1

Conversation

@niazangels

Copy link
Copy Markdown

I noticed the Gzip example is the same as the one for TrustedDomains. You already had the example code. I linked to the correct file and changed the highlights.

This is my first time contributing to this project. Here's what I did:

  • read the page on contributing
  • created the environment locally
  • ran the script to generate the docs
  • tested the modified docs on browser

Please let me know if I missed something, or if you'd like changes.
Thanks for building and maintaining such an awesome project 😃

@codecov

codecov Bot commented Mar 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1150 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          331       331           
  Lines         8085      8085           
=========================================
  Hits          8085      8085           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf88ce...65ad7b1. Read the comment docs.

@niazangels

Copy link
Copy Markdown
Author

Looks like I jumped the gun and missed #1146 , #1068, and #1138.
I'll make sure to look around before submitting something next time.

Cheers!

@niazangels niazangels closed this Mar 23, 2020
@tiangolo

tiangolo commented Apr 6, 2020

Copy link
Copy Markdown
Member

Hehe thanks @niazangels ! 👍 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants