Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Portuguese translation for docs/pt/docs/tutorial/cors.md and docs/pt/docs/tutorial/middleware.md#11916

Merged
alejsdev merged 10 commits into
fastapi:masterfrom
wesinalves:master
Aug 3, 2024
Merged

🌐 Add Portuguese translation for docs/pt/docs/tutorial/cors.md and docs/pt/docs/tutorial/middleware.md#11916
alejsdev merged 10 commits into
fastapi:masterfrom
wesinalves:master

Conversation

@wesinalves

@wesinalves wesinalves commented Jul 29, 2024

Copy link
Copy Markdown
Contributor
  • Add translation for docs/pt/docs/tutorial/cors.md

@alejsdev alejsdev changed the title Add Portuguese translation for docs/pt/docs/tutorial/cors.md 🌐 Add Portuguese translation for docs/pt/docs/tutorial/cors.md Jul 29, 2024
@alejsdev alejsdev added lang-all Translations lang-pt Portuguese translations awaiting-review labels Jul 29, 2024
nazarepiedady
nazarepiedady approved these changes Jul 30, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation seems okay, but I do not understand why the checks fail.

@svlandeg

svlandeg commented Jul 30, 2024

Copy link
Copy Markdown
Member

The translation seems okay, but I do not understand why the checks fail.

Thanks for the review!

The checks were failing because the branch had gone slightly out-of-date with the current master. I've gone ahead and pushed an update to the original branch, and now the tests succeed 🎉

@nazarepiedady

nazarepiedady commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

The translation seems okay, but I do not understand why the checks fail.

Thanks for the review!

The checks were failing because the branch had gone slightly out-of-date with the current master. I've gone ahead and pushed an update to the original branch, and now the tests succeed 🎉

Good.

ceb10n
ceb10n suggested changes Jul 30, 2024
View reviewed changes

@ceb10n ceb10n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! ✨✨

Just some typos to be fixed

Comment thread docs/pt/docs/tutorial/cors.md Outdated
Comment thread docs/pt/docs/tutorial/cors.md Outdated
Comment thread docs/pt/docs/tutorial/cors.md Outdated
Comment thread docs/pt/docs/tutorial/cors.md Outdated
Comment thread docs/pt/docs/tutorial/cors.md Outdated
Comment thread docs/pt/docs/tutorial/cors.md Outdated
@wesinalves

wesinalves commented Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

I've added a new translation for docs/pt/docs/tutorial/middleware.md

ceb10n
ceb10n approved these changes Aug 1, 2024
View reviewed changes

@ceb10n ceb10n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀🚀🚀

I approved, since nothing that I reviewed is "wrong". But if you can change it to keep the standards, it would be nice!

Thank you ✨

Comment thread docs/pt/docs/tutorial/middleware.md Outdated
Comment thread docs/pt/docs/tutorial/middleware.md Outdated
Comment thread docs/pt/docs/tutorial/middleware.md Outdated
@github-actions

github-actions Bot commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 044d18f at: https://e7c9a333.fastapitiangolo.pages.dev

ceb10n
ceb10n suggested changes Aug 1, 2024
View reviewed changes
Comment thread docs/pt/docs/tutorial/middleware.md Outdated
@github-actions

github-actions Bot commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 7755092 at: https://6020b155.fastapitiangolo.pages.dev

@alejsdev alejsdev changed the title 🌐 Add Portuguese translation for docs/pt/docs/tutorial/cors.md 🌐 Add Portuguese translation for docs/pt/docs/tutorial/cors.md and docs/pt/docs/tutorial/middleware.md Aug 3, 2024
@alejsdev alejsdev merged commit 2609348 into fastapi:master Aug 3, 2024
@alejsdev

alejsdev commented Aug 3, 2024

Copy link
Copy Markdown
Member

Great, thanks for the contribution! @wesinalves 🚀 ✨
And thanks for the reviews @ceb10n @cassiobotaro @nazarepiedady @lucasbalieiro 🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@ceb10n ceb10n ceb10n requested changes

@cassiobotaro cassiobotaro cassiobotaro approved these changes

@nazarepiedady nazarepiedady nazarepiedady approved these changes

@lucasbalieiro lucasbalieiro lucasbalieiro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-1 lang-all Translations lang-pt Portuguese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@wesinalves @svlandeg @nazarepiedady @alejsdev @ceb10n @cassiobotaro @lucasbalieiro @tiangolo