📝 Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md#12045
Merged
tiangolo merged 2 commits intoNov 10, 2024
Merged
Conversation
docs/en/docs/tutorial/dependencies/dependencies-with-yield.md
docs/en/docs/tutorial/dependencies/dependencies-with-yield.mddocs/en/docs/tutorial/dependencies/dependencies-with-yield.md
Contributor
|
📝 Docs preview for commit 81bc206 at: https://f04d7eae.fastapitiangolo.pages.dev Modified Pages |
svlandeg
reviewed
Sep 18, 2024
Member
There was a problem hiding this comment.
Hi, thanks for your contribution! 🙏
I'm not sure I fully understand the suggestion here, and what "but before sending it" actually means. You mention that this has changed after FastAPI 0.106.0, can you share a link to the relevant commit/PR/change log?
[UPDATE]: Ah, found it, this is probably related to #10831?
svlandeg
approved these changes
Sep 18, 2024
svlandeg
left a comment
Member
There was a problem hiding this comment.
Yep I think this looks good, thanks again! 🙏
Contributor
|
📝 Docs preview for commit f439898 at: https://e899cbec.fastapitiangolo.pages.dev Modified Pages |
s-rigaud
pushed a commit
to s-rigaud/fastapi
that referenced
this pull request
Jan 23, 2025
…md` (fastapi#12045) Co-authored-by: Sebastián Ramírez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After FastAPI 0.106.0, the code after yield now runs after the response is created but before it is sent to the client.