📝 Update comma in docs/en/docs/async.md#12062
Merged
tiangolo merged 2 commits intoAug 28, 2024
Merged
Conversation
Contributor
|
📝 Docs preview for commit 2ce30c9 at: https://6e853707.fastapitiangolo.pages.dev Modified Pages |
svlandeg
reviewed
Aug 23, 2024
svlandeg
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! I agree that we could make this sentence more readable. I would however suggest to only insert the first comma, so that we don't have a comma followed immediately by "and". The "it can start and it wil end" belongs together in a subsentence, IMO.
Co-authored-by: Sofie Van Landeghem <[email protected]>
Contributor
|
📝 Docs preview for commit ac1efc9 at: https://ca5f4a09.fastapitiangolo.pages.dev Modified Pages |
svlandeg
approved these changes
Aug 26, 2024
docs/en/docs/async.mddocs/en/docs/async.md
Member
|
Cool, thanks! 🤓 |
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Alec Gillis <[email protected]> Co-authored-by: Sofie Van Landeghem <[email protected]>
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Alec Gillis <[email protected]> Co-authored-by: Sofie Van Landeghem <[email protected]>
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Alec Gillis <[email protected]> Co-authored-by: Sofie Van Landeghem <[email protected]>
s-rigaud
pushed a commit
to s-rigaud/fastapi
that referenced
this pull request
Jan 23, 2025
Co-authored-by: Alec Gillis <[email protected]> Co-authored-by: Sofie Van Landeghem <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add commas to a series in a sentence under the Coroutines section to enhance readability.