Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Fix markdown error in Korean translation for docs/ko/docs/tutorial/*.md#12148

Closed
sodaMelon wants to merge 11 commits into
fastapi:masterfrom
sodaMelon:fix-markdown-korean-tutorial
Closed

🌐 Fix markdown error in Korean translation for docs/ko/docs/tutorial/*.md#12148
sodaMelon wants to merge 11 commits into
fastapi:masterfrom
sodaMelon:fix-markdown-korean-tutorial

Conversation

@sodaMelon

Copy link
Copy Markdown

I corrected minor Markdown syntax errors and fixed bold formatting as per the original text.

also modified some typo.

(most problem appeared by markdown, because of korean postposition grammer. anyway maybe it will be better)

@github-actions github-actions Bot added the lang-all Translations label Sep 6, 2024
@github-actions

github-actions Bot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 39e27b4 at: https://a6ed3947.fastapitiangolo.pages.dev

Modified Pages

@sodaMelon

Copy link
Copy Markdown
Author

Korean tutorial text is mostly broken.
This is why I started working on this, but there are still a lot of mistakes.
(i will do it again)

@github-actions

github-actions Bot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 0011ce2 at: https://8e6d4b41.fastapitiangolo.pages.dev

Modified Pages

This reverts commit 0011ce2.
@sodaMelon sodaMelon marked this pull request as draft September 6, 2024 16:13
@sodaMelon

Copy link
Copy Markdown
Author

i did some mistake ( will fix😅)

@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Sep 6, 2024
@github-actions

github-actions Bot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 81ef7aa at: https://23ab3597.fastapitiangolo.pages.dev

Modified Pages

@github-actions

github-actions Bot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit bd002f7 at: https://3e1b4f6b.fastapitiangolo.pages.dev

Modified Pages

@github-actions

github-actions Bot commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 430dd72 at: https://1ce44ba4.fastapitiangolo.pages.dev

Modified Pages

@sodaMelon

Copy link
Copy Markdown
Author

Sorry for creating so much documentation.
(I should have broken up the work like the others.... 😅)

anyway, fixed all the grammatical markdown errors. It should be much more readable than before.
so, it's time to review & merge.

+)
I started doing this after reading Rafael's post in dev.to so I'll keep growing and making fewer mistakes!

@sodaMelon sodaMelon marked this pull request as ready for review September 6, 2024 17:28
@sodaMelon

Copy link
Copy Markdown
Author

If someone could clean up the expired comments by github-action about page, I'd appreciate it.

@sodaMelon sodaMelon changed the title 🌐 Fix Korean translation for docs/ko/docs/tutorial/*.md 🌐 Fix markdown error in Korean translation for docs/ko/docs/tutorial/*.md Sep 7, 2024
@sodaMelon

Copy link
Copy Markdown
Author

hi could you check my PR for fast-api-docs? Most docs are broken, so very hard to read
@hard-coders @jujumilk3 @junah201 @KaniKim

@KaniKim

KaniKim commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

LGTM!

@alejsdev

Copy link
Copy Markdown
Member

Hi @sodaMelon,

This was handled in PR #12509, so I'm closing this one, but thanks for the effort and interest! 🙌

@alejsdev alejsdev closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants