📝 Update link to Swagger UI configuration docs#12264
Conversation
|
📝 Docs preview for commit 5d5754b at: https://0792e14e.fastapitiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit 67cc133 at: https://b2dfe7ba.fastapitiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit dd8a235 at: https://697e2325.fastapitiangolo.pages.dev Modified Pages |
|
📝 Docs preview for commit d6f4150 at: https://422b9590.fastapitiangolo.pages.dev Modified Pages |
Ryandaydev
left a comment
There was a problem hiding this comment.
No objection to the changes if it adds to consistency. However, I don't receive an error when using the original link. It seems to work fine for me.
|
@raccoonyy, indeed, as noted in the linked issue, they (swagger.io team) have resolved the redirection issue. Thanks for your review, I'm absolutely OK if you decide to close the PR and decline the suggested changes as non-necessary. *UPD, yes, indeed, sorry, I mentioned the wrong person, probably miss-clicked on the nick 😅 |
|
@makisukurisu I think I was mentioned in the wrong place. :) |
pjsully
left a comment
There was a problem hiding this comment.
I would suggest this change should be merged. If it works as well as without the trailing /, and also works if redirection for some reason isn't working, it seems like a better solution.
|
Thank you @makisukurisu ✨ |
I've noticed that the old link now leads to the "404 Not found" page on swagger.io, found the new link and updated it wherever possible (there appear to be only 4 languages that even have
configure-swagger-ui.mdpage).Even though it appears to be a problem that should be resolved on swagger.io side, I think that updating the link may be better.
P.S. I've created a bug report in the swagger.io-docs repo.
P.S.S. I still believe it's best to have the trailing slashes at the end of the link, because without them, users are getting 308 Permanent Redirect to other webpage, so adding a / will make life easier for both parties.