Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Traditional Chinese translation for docs/zh-hant/docs/fastapi-cli.md#12444

Merged
alejsdev merged 8 commits into
fastapi:masterfrom
yychanlee:zh_hant_fastapi-cli
Oct 18, 2024
Merged

🌐 Add Traditional Chinese translation for docs/zh-hant/docs/fastapi-cli.md#12444
alejsdev merged 8 commits into
fastapi:masterfrom
yychanlee:zh_hant_fastapi-cli

Conversation

@yychanlee

@yychanlee yychanlee commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the lang-all Translations label Oct 13, 2024
@github-actions

github-actions Bot commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 2d55616 at: https://7d906c51.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev changed the title 🌐 Add Tradiction Chinese translation for docs/zh-hant/docs/fastapi-cli.md 🌐 Add Chinese translation for docs/zh-hant/docs/fastapi-cli.md Oct 14, 2024
@alejsdev alejsdev added the lang-zh-hant Traditional Chinese translations label Oct 14, 2024
@alejsdev alejsdev changed the title 🌐 Add Chinese translation for docs/zh-hant/docs/fastapi-cli.md 🌐 Add Traditional Chinese translation for docs/zh-hant/docs/fastapi-cli.md Oct 14, 2024
mattwang44
mattwang44 reviewed Oct 14, 2024
View reviewed changes
Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
@yychanlee @mattwang44
Update docs/zh-hant/docs/fastapi-cli.md
482dc26 
Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
@github-actions

github-actions Bot commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 482dc26 at: https://26a4c544.fastapitiangolo.pages.dev

Modified Pages

@yychanlee @mattwang44
Update docs/zh-hant/docs/fastapi-cli.md
0fa5cfd 
Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
@github-actions

github-actions Bot commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 0fa5cfd at: https://4a8dabec.fastapitiangolo.pages.dev

Modified Pages

@yychanlee @mattwang44
Update docs/zh-hant/docs/fastapi-cli.md
317dc8e 
Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
@github-actions

github-actions Bot commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 317dc8e at: https://e0bbc92a.fastapitiangolo.pages.dev

Modified Pages

@yychanlee @mattwang44
Update docs/zh-hant/docs/fastapi-cli.md
6c2f8ca 
Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
@github-actions

github-actions Bot commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 6c2f8ca at: https://7cc0a834.fastapitiangolo.pages.dev

Modified Pages

mattwang44
mattwang44 reviewed Oct 14, 2024
View reviewed changes
Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
@mattwang44

mattwang44 commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Note that you can add multiple suggestions into a batch and commit them together
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes

@yychanlee @mattwang44
Apply suggestions from code review
eebc084 
Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
@github-actions

github-actions Bot commented Oct 15, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit eebc084 at: https://c4a7c715.fastapitiangolo.pages.dev

Modified Pages

mattwang44
mattwang44 reviewed Oct 16, 2024
View reviewed changes

@mattwang44 mattwang44 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM

Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
Comment thread docs/zh-hant/docs/fastapi-cli.md Outdated
@yychanlee @mattwang44
Apply suggestions from code review
36f7da5 
Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
@github-actions

github-actions Bot commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 36f7da5 at: https://97bd90e4.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev merged commit b0761c2 into fastapi:master Oct 18, 2024
@alejsdev

alejsdev commented Oct 18, 2024

Copy link
Copy Markdown
Member

Thanks for the contribution! @codingjenny ✨
And thanks for the review @mattwang44 💯

@yychanlee yychanlee deleted the zh_hant_fastapi-cli branch December 15, 2024 03:10
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@yychanlee @s-rigaud
🌐 Add Traditional Chinese translation for `docs/zh-hant/docs/fastapi-…
f7be600 
…cli.md` (fastapi#12444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mattwang44 mattwang44 mattwang44 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-1 lang-all Translations lang-zh-hant Traditional Chinese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yychanlee @mattwang44 @alejsdev