Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Korean translation for docs/ko/docs/benchmarks.md#12540

Merged
alejsdev merged 9 commits into
fastapi:masterfrom
Limsunoh:features/ko-benchmarks
Oct 27, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/benchmarks.md#12540
alejsdev merged 9 commits into
fastapi:masterfrom
Limsunoh:features/ko-benchmarks

Conversation

@Limsunoh

@Limsunoh Limsunoh commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

Started translation of docs/ko/docs/benchmarks.md
Add Korean translation for docs/ko/docs/benchmarks.md

@github-actions github-actions Bot added the lang-all Translations label Oct 25, 2024
@github-actions

github-actions Bot commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit b406f3f at: https://c9ea3678.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev changed the title Add translation to docs/ko/docs/benchmarks.md 🌐 Add Korean translation for docs/ko/docs/benchmarks.md Oct 25, 2024
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 25, 2024
JaeHyuckSa

This comment was marked as duplicate.

Sign in to view

JaeHyuckSa
JaeHyuckSa suggested changes Oct 25, 2024
View reviewed changes

@JaeHyuckSa JaeHyuckSa left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! @Limsunoh, thank you for your contribute. 👍 There are a few revisions needed. (Related issue: #2017)

Comment thread docs/ko/docs/benchmarks.md Outdated
Comment thread docs/ko/docs/benchmarks.md Outdated
Comment thread docs/ko/docs/benchmarks.md Outdated
Comment thread docs/ko/docs/benchmarks.md Outdated
Comment thread docs/ko/docs/benchmarks.md Outdated
Comment thread docs/ko/docs/benchmarks.md Outdated
@github-actions

github-actions Bot commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit e52978e at: https://2d1016f4.fastapitiangolo.pages.dev

Modified Pages

sodaMelon
sodaMelon reviewed Oct 26, 2024
View reviewed changes
Comment thread docs/ko/docs/benchmarks.md Outdated
sodaMelon
sodaMelon reviewed Oct 26, 2024
View reviewed changes
Comment thread docs/ko/docs/benchmarks.md Outdated
sodaMelon
sodaMelon reviewed Oct 26, 2024
View reviewed changes

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi. it's almost perfect
(i left some comments. If you think it's good, reflect it.)

@sodaMelon

sodaMelon commented Oct 26, 2024

Copy link
Copy Markdown

@JaeHyuckSa hi. for application, can we use 응용 프로그램 with 애플리케이션?
응용 프로그램 uses in 7 files
애플리케이션 uses in 12 files.

@JaeHyuckSa

JaeHyuckSa commented Oct 26, 2024

Copy link
Copy Markdown

@JaeHyuckSa hi. for application, can we use 응용 프로그램 with 애플리케이션? 응용 프로그램 uses in 7 files 애플리케이션 uses in 12 files.

Hello @sodaMelon, we refer to the following link when translating into Korean, instead of basing on usage frequency:

#2017

In the case of "application," it can be translated as "응용 프로그램." Please refer to the link below:

https://www.flowdas.com/pages/python-docs-ko.html#:~:text=application%3A%20%EC%9D%91%EC%9A%A9%20%ED%94%84%EB%A1%9C%EA%B7%B8%EB%9E%A8

For consistency, instances of the word "어플리케이션" across multiple files should be modified accordingly.

@sodaMelon

sodaMelon commented Oct 26, 2024

Copy link
Copy Markdown

@JaeHyuckSa hi. for application, can we use 응용 프로그램 with 애플리케이션? 응용 프로그램 uses in 7 files 애플리케이션 uses in 12 files.

Hello @sodaMelon, we refer to the following link when translating into Korean, instead of basing on usage frequency:

#2017

In the case of "application," it can be translated as "응용 프로그램." Please refer to the link below:

https://www.flowdas.com/pages/python-docs-ko.html#:~:text=application%3A%20%EC%9D%91%EC%9A%A9%20%ED%94%84%EB%A1%9C%EA%B7%B8%EB%9E%A8

For consistency, instances of the word "어플리케이션" across multiple files should be modified accordingly.

oh thanks. i understand

@github-actions

github-actions Bot commented Oct 26, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 778e829 at: https://c52be65c.fastapitiangolo.pages.dev

Modified Pages

Limsunoh
Limsunoh commented Oct 26, 2024
View reviewed changes

@Limsunoh Limsunoh left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your help.

Comment thread docs/ko/docs/benchmarks.md Outdated
sodaMelon
sodaMelon approved these changes Oct 27, 2024
View reviewed changes

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejsdev alejsdev enabled auto-merge (squash) October 27, 2024 15:01
@alejsdev alejsdev merged commit 8d928de into fastapi:master Oct 27, 2024
@alejsdev

alejsdev commented Oct 27, 2024

Copy link
Copy Markdown
Member

Thanks so much for your interest in contributing to FastAPI! @Limsunoh @sodaMelon @JaeHyuckSa 🚀

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@Limsunoh @s-rigaud
🌐 Add Korean translation for docs/ko/docs/benchmarks.md (fastapi#12540
e06d5b8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sodaMelon sodaMelon sodaMelon approved these changes

@JaeHyuckSa JaeHyuckSa JaeHyuckSa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Limsunoh @sodaMelon @JaeHyuckSa @alejsdev