Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Korean Translation for docs/ko/docs/advanced/response-cookies.md#12546

Merged
alejsdev merged 9 commits into
fastapi:masterfrom
kim-sangah:features/ko-advanced-response-cookies
Oct 29, 2024
Merged

🌐 Add Korean Translation for docs/ko/docs/advanced/response-cookies.md#12546
alejsdev merged 9 commits into
fastapi:masterfrom
kim-sangah:features/ko-advanced-response-cookies

Conversation

@kim-sangah

Copy link
Copy Markdown
Contributor

Add translation to docs/ko/docs/advanced/response-cookies.md

@github-actions github-actions Bot added the lang-all Translations label Oct 25, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Comment thread docs/ko/docs/advanced/response-cookies.md Outdated
Comment thread docs/ko/docs/advanced/response-cookies.md Outdated
Comment thread docs/ko/docs/advanced/response-cookies.md Outdated
이를 위해 [Response를 직접 반환하기](response-directly.md){.internal-link target=_blank}에서 설명한 대로 응답을 생성할 수 있습니다.

그런 다음 쿠키를 설정하고 반환하면 됩니다:
Python hl_lines="10-12"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check the new created documentation?
it is broken from here.

@kim-sangah kim-sangah Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the mark and changed it! [```]

@sodaMelon

sodaMelon commented Oct 26, 2024

Copy link
Copy Markdown

hi i left some comment for PR.
please check it when you are not busy

P.S : It's better to add 🌐 in front of your PR subject

@alejsdev alejsdev changed the title Add translation to docs/ko/docs/advanced/response-cookies.md 🌐 Add Korean Translation for docs/ko/docs/advanced/response-cookies.md Oct 26, 2024
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 26, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Update docs/ko/docs/advanced/response-cookies.md
@github-actions

Copy link
Copy Markdown
Contributor

@kim-sangah kim-sangah requested a review from sodaMelon October 28, 2024 08:32

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions

Copy link
Copy Markdown
Contributor

@JaeHyuckSa JaeHyuckSa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! @kim-sangah, thank you for your contribute. 👍 There are a few revisions needed. (Related issue: #2017)

Comment thread docs/ko/docs/advanced/response-cookies.md Outdated
Comment thread docs/ko/docs/advanced/response-cookies.md Outdated
Comment thread docs/ko/docs/advanced/response-cookies.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev enabled auto-merge (squash) October 29, 2024 10:32
@alejsdev alejsdev merged commit 3f82281 into fastapi:master Oct 29, 2024
@alejsdev

Copy link
Copy Markdown
Member

Thanks! @kim-sangah 🎉
And thanks for the reviews @sodaMelon @JaeHyuckSa 🤓

@kim-sangah kim-sangah deleted the features/ko-advanced-response-cookies branch October 30, 2024 13:50
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants