Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🌐 Add Korean translation for docs/ko/docs/advanced/wsgi.md#12659

Merged
alejsdev merged 9 commits into
fastapi:masterfrom
Limsunoh:features/ko-advanced-wsgi
Oct 31, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/advanced/wsgi.md#12659
alejsdev merged 9 commits into
fastapi:masterfrom
Limsunoh:features/ko-advanced-wsgi

Conversation

@Limsunoh

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the lang-all Translations label Oct 28, 2024
@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 28, 2024
@alejsdev alejsdev changed the title Add translation to docs/ko/docs/advanced/wsgi.md 🌐 Add Korean Translation for docs/ko/docs/advanced/wsgi.md Oct 28, 2024
@alejsdev alejsdev changed the title 🌐 Add Korean Translation for docs/ko/docs/advanced/wsgi.md 🌐 Add Korean translation for docs/ko/docs/advanced/wsgi.md Oct 28, 2024

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! However, some points need improvement. I believe reading others' translations will help you.

Comment thread docs/ko/docs/advanced/wsgi.md Outdated
Comment thread docs/ko/docs/advanced/wsgi.md Outdated
Comment thread docs/ko/docs/advanced/wsgi.md Outdated
Comment thread docs/ko/docs/advanced/wsgi.md Outdated
Comment thread docs/ko/docs/advanced/wsgi.md Outdated
Comment thread docs/ko/docs/advanced/wsgi.md Outdated
Comment thread docs/ko/docs/advanced/wsgi.md Outdated

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Limsunoh i left some comment to read better.
번역에서는 기본적으로 ~습니다 를 쓰게되어있어서
어투만 교정했습니다.
나머지는 @hard-coders 님 코멘트를 확인하세요!

@github-actions

Copy link
Copy Markdown
Contributor

Limsunoh and others added 3 commits October 31, 2024 17:09
"Thank you for explaining it so well

Co-authored-by: sodam <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alejsdev alejsdev enabled auto-merge (squash) October 31, 2024 18:56
@alejsdev alejsdev merged commit 14b087c into fastapi:master Oct 31, 2024
@alejsdev

Copy link
Copy Markdown
Member

Nice, thank you! @Limsunoh 🥳
And thanks for the reviews @hard-coders @sodaMelon 🎉

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants