Thanks to visit codestin.com
Credit goes to github.com

Skip to content

📝 Update includes for docs/de/docs/python-types.md#12660

Merged
alejsdev merged 2 commits into
fastapi:masterfrom
alissadb:include-python-types
Nov 9, 2024
Merged

📝 Update includes for docs/de/docs/python-types.md#12660
alejsdev merged 2 commits into
fastapi:masterfrom
alissadb:include-python-types

Conversation

@alissadb

Copy link
Copy Markdown
Contributor

📝 Update includes for docs/de/docs/python-types.md

@github-actions github-actions Bot added the lang-all Translations label Oct 28, 2024
@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev closed this Oct 28, 2024
@alejsdev

Copy link
Copy Markdown
Member

Hi @alissadb, thanks for your interest in contributing to FastAPI. However, this is a special case, you have to stick to the previous version in some of the cases, see #12551 for reference.

If you want you can adjust it, I'll reopen it in the meantime. Thanks! 🙌

@alejsdev alejsdev reopened this Oct 28, 2024
@alejsdev alejsdev added changes-requested docs Documentation about how to use FastAPI and removed lang-all Translations labels Oct 28, 2024
@github-actions github-actions Bot added the lang-all Translations label Oct 28, 2024
@alejsdev alejsdev removed the lang-all Translations label Oct 28, 2024
@github-actions github-actions Bot added the lang-all Translations label Oct 28, 2024
@alejsdev alejsdev removed the lang-all Translations label Oct 28, 2024
@alissadb

Copy link
Copy Markdown
Contributor Author

@alejsdev Thank you! I have updated the PR, I noticed than in the previous PR this was not changed. Should I also keep it unchanged as well?

@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev

Copy link
Copy Markdown
Member

Hi @alissadb, it would depend on the context.
In the original we kept the old version in some cases as it has some additional explanations (https://fastapi.tiangolo.com/python-types/)

The ideas is to keep this consistency in other languages.

@alejsdev alejsdev merged commit 890a61f into fastapi:master Nov 9, 2024
@alejsdev

alejsdev commented Nov 9, 2024

Copy link
Copy Markdown
Member

Thanks for your help! @alissadb 🚀

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants